Initial setup for file serve #1242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When editing a file on my macOS (Orbstack) I only get this: and the file is not re-rendered. |
|
On macOS with the recent change and some deprecation messages in the Ratchet lib / interface, the files do get re-rendered. Looking forward for more :) |
jaapio
force-pushed
the
feature/change-serve
branch
from
e176065 to
dcbe320
Compare
With this change we provide an internal webserver in the application. And introduce a watch on changes. This introduces a new way of working with guides, allowing users to edit documentation without caring about rerendering. Optimizations are possible like parsing and rendering a single file to make rerendering faster.
jaapio
force-pushed
the
feature/change-serve
branch
from
dcbe320 to
de29766
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we provide an internal webserver in the application. And introduce a watch on changes. This introduces a new way of working with guides, allowing users to edit documentation without caring about rerendering.
Optimizations are possible like parsing and rendering a single file to make rerendering faster.
To test this you can run the following steps:
We need to build a local docker image because we need some extra php extension to watch file changes.