Bug: dependencies leak between files (#445)

this fixes #389

Author: simivar

src/Analyzer/FileVisitor.php

@@ -243,6 +243,7 @@ public function getClassDescriptions(): array
     public function clearParsedClassDescriptions(): void
     {
         $this->classDescriptions = [];
+        $this->classDescriptionBuilder->clear();
     }
 
     public function leaveNode(Node $node): void

tests/E2E/Cli/CheckCommandTest.php

@@ -146,6 +146,13 @@ public function test_you_can_ignore_the_default_baseline(): void
         $this->assertCheckHasErrors($cmdTester);
     }
 
+    public function test_dependencies_should_not_leak_between_files(): void
+    {
+        $cmdTester = $this->runCheck(__DIR__.'/../_fixtures/configDependenciesLeak.php');
+
+        $this->assertCheckHasSuccess($cmdTester);
+    }
+
     public function test_baseline_line_numbers_can_be_ignored(): void
     {
         $configFilePath = __DIR__.'/../_fixtures/configIgnoreBaselineLineNumbers.php';

tests/E2E/_fixtures/DependenciesLeak/FirstModule/Router.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\DependenciesLeak\FirstModule;
+
+class Router
+{
+    public static function define(): void
+    {
+    }
+}

tests/E2E/_fixtures/DependenciesLeak/FirstModule/routes.php

@@ -0,0 +1,7 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\DependenciesLeak\FirstModule;
+
+Router::define();

tests/E2E/_fixtures/DependenciesLeak/SecondModule/SomeClass.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\DependenciesLeak\SecondModule;
+
+class SomeClass
+{
+}

tests/E2E/_fixtures/configDependenciesLeak.php

@@ -0,0 +1,20 @@
+<?php
+declare(strict_types=1);
+
+use Arkitect\ClassSet;
+use Arkitect\CLI\Config;
+use Arkitect\Expression\ForClasses\NotDependsOnTheseNamespaces;
+use Arkitect\Expression\ForClasses\ResideInOneOfTheseNamespaces;
+use Arkitect\Rules\Rule;
+
+return static function (Config $config): void {
+    $dependenciesLeakClassSet = ClassSet::fromDir(__DIR__.'/DependenciesLeak');
+
+    $rule_1 = Rule::allClasses()
+        ->that(new ResideInOneOfTheseNamespaces('App\DependenciesLeak\SecondModule'))
+        ->should(new NotDependsOnTheseNamespaces('App\DependenciesLeak\FirstModule'))
+        ->because('modules should be independent');
+
+    $config
+        ->add($dependenciesLeakClassSet, ...[$rule_1]);
+};