fix isFinal, isAbstract, isReadonly behaviour

Author: micheleorselli

src/Expression/ForClasses/IsAbstract.php

@@ -20,8 +20,7 @@ public function describe(ClassDescription $theClass, string $because): Descripti
 
     public function evaluate(ClassDescription $theClass, Violations $violations, string $because): void
     {
-        if ($theClass->isAbstract() || $theClass->isInterface() || $theClass->isTrait() || $theClass->isEnum()
-            || $theClass->isFinal()) {
+        if ($theClass->isAbstract()) {
             return;
         }
 

src/Expression/ForClasses/IsFinal.php

@@ -20,8 +20,7 @@ public function describe(ClassDescription $theClass, string $because): Descripti
 
     public function evaluate(ClassDescription $theClass, Violations $violations, string $because): void
     {
-        if ($theClass->isAbstract() || $theClass->isInterface() || $theClass->isFinal() || $theClass->isTrait()
-            || $theClass->isEnum()) {
+        if ($theClass->isFinal()) {
             return;
         }
 

src/Expression/ForClasses/IsReadonly.php

@@ -20,7 +20,7 @@ public function describe(ClassDescription $theClass, string $because): Descripti
 
     public function evaluate(ClassDescription $theClass, Violations $violations, string $because): void
     {
-        if ($theClass->isReadonly() || $theClass->isInterface() || $theClass->isTrait() || $theClass->isEnum()) {
+        if ($theClass->isReadonly()) {
             return;
         }
 

tests/E2E/PHPUnit/CheckClassWithMultipleExpressionsTest.php

@@ -1,9 +1,12 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Arkitect\Tests\E2E\PHPUnit;
 
 use Arkitect\ClassSet;
+use Arkitect\Expression\ForClasses\HaveNameMatching;
+use Arkitect\Expression\ForClasses\IsAbstract;
 use Arkitect\Expression\ForClasses\IsNotAbstract;
 use Arkitect\Expression\ForClasses\IsNotEnum;
 use Arkitect\Expression\ForClasses\IsNotFinal;
@@ -33,4 +36,16 @@ public function test_it_can_check_multiple_expressions(): void
 
         ArchRuleTestCase::assertArchRule($rule, $set);
     }
+
+    public function test_is_final(): void
+    {
+        $set = ClassSet::fromDir(__DIR__.'/../_fixtures/is_final');
+
+        $rule = Rule::allClasses()
+            ->that(new IsAbstract())
+            ->should(new HaveNameMatching('Abstract*'))
+            ->because('we want to prefix abstract classes');
+
+        ArchRuleTestCase::assertArchRule($rule, $set);
+    }
 }

tests/E2E/_fixtures/is_final/MyClass.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App;
+
+final class MyClass
+{
+}