wip

Author: AlessandroMinoccheri

src/Analyzer/NameResolver.php

@@ -142,13 +142,17 @@ public function enterNode(Node $node)
             $tokenIterator = new TokenIterator($tokens);
             $phpDocNode = $phpDocParser->parse($tokenIterator);
 
-            foreach ($phpDocNode->getVarTagValues() as $tagValue) {
+            foreach ($phpDocNode->getTags() as $tagValue) {
+                if (!property_exists($tagValue, 'type')) {
+                    continue;
+                }
+
                 $type = $this->resolveName(new Node\Name((string) $tagValue->type), Use_::TYPE_NORMAL);
                 $node->type = $type;
                 break;
             }
 
-            if (null === $node->type) {
+            if (null === $node->type || !($node->type instanceof FullyQualified)) {
                 foreach ($phpDocNode->getTags() as $tagValue) {
                     if ('@' === $tagValue->name[0] && false === strpos($tagValue->name, '@var')) {
                         $customTag = str_replace('@', '', $tagValue->name);

tests/Unit/Analyzer/FileVisitorTest.php

@@ -649,17 +649,13 @@ public function test_should_implement_exact_classname(): void
     {
         $code = <<< 'EOF'
 <?php
-
 namespace Foo;
-
 interface Order
 {
 }
-
 interface OrderTwo
 {
 }
-
 class test implements Order
 {
 }
@@ -678,4 +674,38 @@ class test implements Order
 
         $this->assertCount(0, $violations, $violations->toString());
     }
+
+    public function test_it_parse_dependencies_in_docblocks_with_alias(): void
+    {
+        $code = <<< 'EOF'
+<?php
+namespace MyProject\AppBundle\Application;
+use Symfony\Component\Validator\Constraints as Assert;
+use Symfony\Test;
+class ApplicationLevelDto
+{
+    /**
+     * @Assert\NotBlank
+     */
+    public string|null $foo;
+    /**
+        * @var Test
+    */
+    public $bar;
+}
+EOF;
+
+        /** @var FileParser $fp */
+        $fp = FileParserFactory::createFileParser(TargetPhpVersion::create('8.1'));
+        $fp->parse($code, 'relativePathName');
+
+        $cd = $fp->getClassDescriptions();
+
+        $violations = new Violations();
+
+        $notHaveDependencyOutsideNamespace = new DependsOnlyOnTheseNamespaces('MyProject\AppBundle\Application');
+        $notHaveDependencyOutsideNamespace->evaluate($cd[0], $violations, 'we want to add this rule for our software');
+
+        $this->assertCount(1, $violations);
+    }
 }