Fix pattern match (#404)

Author: hgraca

src/Analyzer/PatternString.php

@@ -27,7 +27,7 @@ public function matches(string $pattern): bool
             return $isInThisNamespace || $isThisClass;
         }
 
-        return $this->startsWithPattern($pattern);
+        return fnmatch($pattern, $this->value, \FNM_NOESCAPE);
     }
 
     public function toString(): string
@@ -43,20 +43,4 @@ private function containsWildcard(string $pattern): bool
             || str_contains($pattern, '.')
             || str_contains($pattern, '[');
     }
-
-    private function startsWithPattern(string $pattern): bool
-    {
-        return 1 === preg_match('#^'.$this->convertShellToRegExPattern($pattern).'#', $this->value);
-    }
-
-    private function convertShellToRegExPattern(string $pattern): string
-    {
-        return strtr($pattern, [
-            '*' => '.*',
-            '?' => '.',
-            '.' => '\.',
-            '[!' => '[^',
-            '\\' => '\\\\',
-        ]);
-    }
 }

src/Expression/ForClasses/ResideInOneOfTheseNamespaces.php

@@ -32,7 +32,7 @@ public function evaluate(ClassDescription $theClass, Violations $violations, str
     {
         $resideInNamespace = false;
         foreach ($this->namespaces as $namespace) {
-            if ($theClass->namespaceMatches($namespace)) {
+            if ($theClass->namespaceMatches($namespace.'*')) {
                 $resideInNamespace = true;
             }
         }

tests/Unit/Analyzer/PatternStringTest.php

@@ -15,10 +15,32 @@ public function test_it_works_for_simple_strings(): void
         $this->assertFalse($pattern->matches('Something else'));
     }
 
-    public function test_wildcard_is_for_alphanumeric(): void
+    /**
+     * @dataProvider providePatterns
+     */
+    public function test_wildcard_is_for_alphanumeric(string $string, string $pattern, bool $expectedResult): void
     {
-        $pattern = new PatternString('SoThisIsAnExample');
-        $this->assertTrue($pattern->matches('*This*'));
-        $this->assertFalse($pattern->matches('This*'));
+        $this->assertEquals($expectedResult, (new PatternString($string))->matches($pattern));
+    }
+
+    public function providePatterns(): array
+    {
+        return [
+            ['SoThisIsAnExample', '*This*', true],
+            ['SoThisIsAnExample', 'This*', false],
+            ['SoThisIsAnExample', '*This', false],
+            ['SoThisIsAnExample', 'SoThisIsAnExample', true],
+            ['SoThisIsAnExample', 'So????????Example', true],
+            ['SoThisIsAnExample', '*SoThisIsAnExample', true],
+            ['SoThisIsAnExample', 'SoThisIsAnExample*', true],
+            ['SoThisIsAnExample', 'So*Example', true],
+            ['SoThisIsAnExample', '*ThisIsAnExample', true],
+            ['SoThisIsAnExample', 'SoThisIsAn*', true],
+            ['Food\Vegetables\Roots\Carrot', 'Food\*\Roots', false],
+            ['Food\Vegetables\Roots\Orange\Carrot', 'Food\*\Roots', false],
+            ['Food\Vegetables\Carrot', '*\Vegetables', false],
+            ['Food\Vegetables\Roots\Carrot', '*\Vegetables', false],
+            ['Food\Vegetables\Roots\Orange\Carrot', '*\Vegetables', false],
+        ];
     }
 }