Skip to content

Commit 9be9ab4

Browse files
committed
code review changes
1 parent f7a0080 commit 9be9ab4

File tree

5 files changed

+10
-18
lines changed

5 files changed

+10
-18
lines changed

.github/workflows/build.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ on:
99

1010
jobs:
1111
build:
12-
runs-on: ubuntu-latest
12+
runs-on: ubuntu-24.04
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
php-versions: [ '8.2', '8.3', '8.4']
16+
php-versions: [ '8.0', '8.1', '8.2', '8.3', '8.4']
1717
coverage-driver: [ 'pcov' ]
1818

1919
steps:
@@ -58,15 +58,15 @@ jobs:
5858
token: ${{ secrets.CODECOV_TOKEN }}
5959

6060
phar:
61-
runs-on: ubuntu-latest
61+
runs-on: ubuntu-24.04
6262
needs: build
6363
steps:
6464
- uses: actions/checkout@v3
6565

6666
- name: Install PHP
6767
uses: shivammathur/setup-php@v2
6868
with:
69-
php-version: 8.4
69+
php-version: 8.0
7070
tools: composer:v2.8
7171
env:
7272
GITHUB_TOKEN: ${{ secrets.TOKEN_GITHUB }}
@@ -92,10 +92,10 @@ jobs:
9292

9393
smoke-test-phar:
9494
needs: phar
95-
runs-on: ubuntu-latest
95+
runs-on: ubuntu-24.04
9696
strategy:
9797
matrix:
98-
php-versions: [ '8.2', '8.3', '8.4' ]
98+
php-versions: [ '8.0', '8.1', '8.2', '8.3', '8.4' ]
9999

100100
steps:
101101
- name: Install PHP
@@ -116,7 +116,7 @@ jobs:
116116

117117
publish_phar:
118118
needs: [build, smoke-test-phar]
119-
runs-on: ubuntu-latest
119+
runs-on: ubuntu-24.04
120120
if: github.event_name == 'release'
121121
steps:
122122
- name: "Download phar ./phparkitect-${{ github.sha }}.phar"
@@ -135,7 +135,7 @@ jobs:
135135

136136
publish_docker_images:
137137
needs: [build, smoke-test-phar]
138-
runs-on: ubuntu-latest
138+
runs-on: ubuntu-24.04
139139

140140
if: github.ref == 'refs/heads/main' || github.event_name == 'release'
141141
steps:

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
ARG PHP_VERSION=8.4
1+
ARG PHP_VERSION=8.0
22

33
FROM php:${PHP_VERSION}-cli-alpine AS php_build
44

src/CLI/Progress/ProgressBarProgress.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
class ProgressBarProgress implements Progress
1717
{
18-
private \Symfony\Component\Console\Output\NullOutput|OutputInterface $output;
18+
private OutputInterface $output;
1919

2020
private ProgressBar $progress;
2121

src/CLI/TargetPhpVersion.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@
99
class TargetPhpVersion
1010
{
1111
public const VALID_PHP_VERSIONS = [
12-
'7.1',
13-
'7.2',
14-
'7.3',
15-
'7.4',
1612
'8.0',
1713
'8.1',
1814
'8.2',

tests/Unit/Expressions/ForClasses/ResideInOneOfTheseNamespacesTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,6 @@ public static function shouldMatchNamespacesProvider(): array
3030

3131
/**
3232
* @dataProvider shouldMatchNamespacesProvider
33-
*
34-
* @param mixed $expectedNamespace
35-
* @param mixed $actualFQCN
36-
* @param mixed $explanation
3733
*/
3834
public function test_it_should_match_namespace_and_descendants(string $expectedNamespace, string $actualFQCN, string $explanation): void
3935
{

0 commit comments

Comments
 (0)