Remove not used type arg from GROUP BY

It should not be there since beginning.

Issue #154

Signed-off-by: Michal Čihař <[email protected]>

Author: nijel

src/Components/GroupKeyword.php

@@ -21,29 +21,20 @@
 class GroupKeyword extends Component
 {
     /**
-     * The expression that is used for ordering.
+     * The expression that is used for grouping.
      *
      * @var Expression
      */
     public $expr;
-    
-    /**
-     * The order type.
-     *
-     * @var string
-     */
-    public $type;
 
     /**
      * Constructor.
      *
      * @param Expression $expr the expression that we are sorting by
-     * @param string     $type the sorting type
      */
-    public function __construct($expr = null, $type = '')
+    public function __construct($expr = null)
     {
         $this->expr = $expr;
-        $this->type = $type;
     }
 
     /**
@@ -135,7 +126,7 @@ public static function build($component, array $options = array())
             return implode(', ', $component);
         }
 
-        return trim($component->expr . ' ' . $component->type);
+        return trim($component->expr);
 
     }
 }

tests/Builder/SelectStatementTest.php

@@ -46,7 +46,7 @@ public function testBuilderAlias()
         $this->assertEquals(
             'SELECT  sgu.id, sgu.email_address FROM `sf_guard_user` AS `sgu` '
             . 'RIGHT JOIN `student_course_booking` AS `scb` ON sgu.id = scb.user_id '
-            . 'WHERE `has_found_course` = \'1\' GROUP BY sgu.id ASC '
+            . 'WHERE `has_found_course` = \'1\' GROUP BY sgu.id '
             . 'ORDER BY scb.id DESC LIMIT 0, 300 ',
             $stmt->build()
         );

tests/Components/GroupKeywordTest.php

@@ -13,12 +13,12 @@ public function testBuild()
         $this->assertEquals(
             GroupKeyword::build(
                 array(
-                    new GroupKeyword(new Expression('a'), 'ASC'),
-                    new GroupKeyword(new Expression('b'), 'DESC'),
+                    new GroupKeyword(new Expression('a')),
+                    new GroupKeyword(new Expression('b')),
                     new GroupKeyword(new Expression('c')),
                 )
             ),
-            'a ASC, b DESC, c'
+            'a, b, c'
         );
     }
 }