Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to check for non static dataprovider even without deprecation rules #162

Closed
VincentLanglet opened this issue Feb 3, 2023 · 1 comment

Comments

@VincentLanglet
Copy link
Contributor

I saw #151 was added by @villfa to check for non static data provider.
But I don't have the check on my project.

If I understand correctly, it's only active if https://github.com/phpstan/phpstan-deprecation-rules is installed.
But I'd like to have this rule even if I don't use the deprecation-rules package.

Currently stricter analysis (https://phpstan.org/config-reference#stricter-analysis) with PHPStan is possible

  • By installing the strict-rules packages
  • By enabling manually some extra config options.

I'd like the same for the non-static check, ie: a config option to enable this rules (which would be automatically set to true if https://github.com/phpstan/phpstan-deprecation-rules is installed).

Is it possible ?
Is it already possible and I miss something ?

Thanks

@ondrejmirtes
Copy link
Member

It's a deprecation -> use the deprecation-rules package. I don't see why not.

@phpstan phpstan locked and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants