Add support for PHPUnit 12.0.9

[VincentLanglet]

See sebastianbergmann/phpunit#6156 (comment)

In 12.0.9 PHPUnit removed the InvocationMocker classes, the PR is sebastianbergmann/phpunit@fb4df53

Current references are

• phpstan-phpunit/stubs/InvocationMocker.stub

  Line 10 in 0f857bf

  class InvocationMocker

• phpstan-phpunit/src/Type/PHPUnit/InvocationMockerDynamicReturnTypeExtension.php

  Line 12 in 0f857bf

  class InvocationMockerDynamicReturnTypeExtension implements DynamicMethodReturnTypeExtension

• phpstan-phpunit/extension.neon

  Line 15 in 0f857bf

  - stubs/InvocationMocker.stub

• phpstan-phpunit/src/Type/PHPUnit/MockObjectDynamicReturnTypeExtension.php

  Line 12 in 0f857bf

  use PHPUnit\Framework\MockObject\Builder\InvocationMocker;

• phpstan-phpunit/src/Rules/PHPUnit/MockMethodCallRule.php

  Line 10 in 0f857bf

  use PHPUnit\Framework\MockObject\Builder\InvocationMocker;

I feel like PHPUnit\Framework\MockObject\Builder\InvocationMocker was basically replaced by PHPUnit\Framework\MockObject\InvocationStubberImplementation

Currently don't know if it will require a StubFilesExtensionLoader like this one
https://github.com/phpstan/phpstan-doctrine/blob/2.0.x/src/Stubs/Doctrine/StubFilesExtensionLoader.php
or if a there is a better strategy.

One first step would be to test this lib with phpunit 10/11 (and 12) but it's currently forbidden by the hardcoded php config

phpstan-phpunit/composer.json

Lines 19 to 24 in 0f857bf

	"phpunit/phpunit": "^9.6"
	},
	"config": {
	"platform": {
	"php": "7.4.6"
	},

[sebastianbergmann]

I also remember talking to Ondrej and/or Markus last year about whether the stubs in phpstan-phpunit are still needed. Ideally, this part of this extension can just be removed.

[VincentLanglet]

I also remember talking to Ondrej and/or Markus last year about whether the stubs in phpstan-phpunit are still needed. Ideally, this part of this extension can just be removed.

I assume that some of this code might be conditionally removed for recent version of phpunit but not all of them.

For instance the MockMethodCallRule is made to report code like

$this->createMock(Bar::class)->method('nonExistingMethod');

Those file were introduced in #72,

• MockMethodCallRule for the rule
• InvocationMocker.stub in order to add @template TMockedClass in order to keep trace of the original class mocked
• MockObjectDynamicReturnTypeExtension to tell phpstan that MockObject&Foo::expects will returns InvocationMocker<Foo>.
• InvocationMockerDynamicReturnTypeExtension to tell phpstan that InvocationMocker methods are returning the same object with the same generic. => Maybe not needed anymore since most of method are annotated with @return $this ?

[sebastianbergmann]

Maybe not needed anymore since most of method are annotated with @return $this?

I just found one more method (see sebastianbergmann/phpunit@4b7f2a8) that is part of the public API for configuring test doubles which was missing @return $this. So hopefully with the next release, PHPUnit 12.0.10, all relevant methods will have this.

[SamMousa]

I can confirm that without the extension PHPStan works fine for the mocks.