Fix

Author: VincentLanglet

build/baseline-8.0.neon

@@ -25,11 +25,6 @@ parameters:
 			count: 1
 			path: ../src/Type/Php/StrSplitFunctionReturnTypeExtension.php
 
-		-
-			message: "#^Strict comparison using \\=\\=\\= between list<string> and false will always evaluate to false\\.$#"
-			count: 1
-			path: ../src/Type/Php/StrSplitFunctionReturnTypeExtension.php
-
 		-
 			message: "#^Call to function is_bool\\(\\) with string will always evaluate to false\\.$#"
 			count: 1

src/Type/Php/StrSplitFunctionReturnTypeExtension.php

@@ -94,9 +94,6 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 					$items = $encoding === null
 						? str_split($constantString->getValue(), $splitLength)
 						: @mb_str_split($constantString->getValue(), $splitLength, $encoding);
-					if ($items === false) {
-						throw new ShouldNotHappenException();
-					}
 
 					$results[] = self::createConstantArrayFrom($items, $scope);
 				}

tests/PHPStan/Analyser/data/mb-str-split-php80.php

@@ -26,7 +26,7 @@ public function legacyTest(): void
 		assertType('array{\'abcdef\'}', $mbStrSplitConstantStringWithGreaterSplitLengthThanStringLength);
 
 		$mbStrSplitConstantStringWithFailureSplitLength = mb_str_split('abcdef', 0);
-		assertType('false', $mbStrSplitConstantStringWithFailureSplitLength);
+		assertType('*NEVER*', $mbStrSplitConstantStringWithFailureSplitLength);
 
 		$mbStrSplitConstantStringWithInvalidSplitLengthType = mb_str_split('abcdef', []);
 		assertType('non-empty-list<non-empty-string>', $mbStrSplitConstantStringWithInvalidSplitLengthType);

tests/PHPStan/Analyser/data/str-split-php80.php

@@ -25,7 +25,7 @@ public function legacyTest() {
 		assertType('array{\'abcdef\'}', $strSplitConstantStringWithGreaterSplitLengthThanStringLength);
 
 		$strSplitConstantStringWithFailureSplitLength = str_split('abcdef', 0);
-		assertType('false', $strSplitConstantStringWithFailureSplitLength);
+		assertType('*NEVER*', $strSplitConstantStringWithFailureSplitLength);
 
 		$strSplitConstantStringWithInvalidSplitLengthType = str_split('abcdef', []);
 		assertType('non-empty-list<non-empty-string>', $strSplitConstantStringWithInvalidSplitLengthType);

tests/PHPStan/Analyser/data/str-split-php82.php

@@ -25,7 +25,7 @@ public function legacyTest() {
 		assertType('array{\'abcdef\'}', $strSplitConstantStringWithGreaterSplitLengthThanStringLength);
 
 		$strSplitConstantStringWithFailureSplitLength = str_split('abcdef', 0);
-		assertType('false', $strSplitConstantStringWithFailureSplitLength);
+		assertType('*NEVER*', $strSplitConstantStringWithFailureSplitLength);
 
 		$strSplitConstantStringWithInvalidSplitLengthType = str_split('abcdef', []);
 		assertType('non-empty-list<non-empty-string>', $strSplitConstantStringWithInvalidSplitLengthType);