From 70f0241b47034ce94aa50cccb07c2022854197af Mon Sep 17 00:00:00 2001
From: Jacob Tobiasz <jakub.tobiasz@icloud.com>
Date: Wed, 5 Feb 2025 20:25:20 +0100
Subject: [PATCH] Add handling an attempt to declare a hooked property static

---
 Makefile                                       |  1 +
 src/Rules/Properties/PropertyInClassRule.php   | 11 +++++++++++
 .../Properties/PropertyInClassRuleTest.php     | 18 ++++++++++++++++++
 .../data/static-hooked-properties.php          | 18 ++++++++++++++++++
 4 files changed, 48 insertions(+)
 create mode 100644 tests/PHPStan/Rules/Properties/data/static-hooked-properties.php

diff --git a/Makefile b/Makefile
index ab0a439c3b..217628bdf6 100644
--- a/Makefile
+++ b/Makefile
@@ -90,6 +90,7 @@ lint:
 		--exclude tests/PHPStan/Rules/Properties/data/hooked-properties-without-bodies-in-class.php \
 		--exclude tests/PHPStan/Rules/Properties/data/readonly-property-hooks.php \
 		--exclude tests/PHPStan/Rules/Properties/data/readonly-property-hooks-in-interface.php \
+		--exclude tests/PHPStan/Rules/Properties/data/static-hooked-properties.php \
 		--exclude tests/PHPStan/Rules/Classes/data/bug-12281.php \
 		--exclude tests/PHPStan/Rules/Traits/data/bug-12281.php \
 		--exclude tests/PHPStan/Rules/Classes/data/invalid-hooked-properties.php \
diff --git a/src/Rules/Properties/PropertyInClassRule.php b/src/Rules/Properties/PropertyInClassRule.php
index 50e3880013..5581695246 100644
--- a/src/Rules/Properties/PropertyInClassRule.php
+++ b/src/Rules/Properties/PropertyInClassRule.php
@@ -92,6 +92,17 @@ public function processNode(Node $node, Scope $scope): array
 			}
 		}
 
+		if ($node->isStatic()) {
+			if ($node->hasHooks()) {
+				return [
+					RuleErrorBuilder::message('Hooked properties cannot be static.')
+						->nonIgnorable()
+						->identifier('property.hookStatic')
+						->build(),
+				];
+			}
+		}
+
 		return [];
 	}
 
diff --git a/tests/PHPStan/Rules/Properties/PropertyInClassRuleTest.php b/tests/PHPStan/Rules/Properties/PropertyInClassRuleTest.php
index 6d61e5c7cc..de0f3b2251 100644
--- a/tests/PHPStan/Rules/Properties/PropertyInClassRuleTest.php
+++ b/tests/PHPStan/Rules/Properties/PropertyInClassRuleTest.php
@@ -177,4 +177,22 @@ public function testPhp84AndReadonlyHookedProperties(): void
 		]);
 	}
 
+	public function testPhp84AndStaticHookedProperties(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4 or later.');
+		}
+
+		$this->analyse([__DIR__ . '/data/static-hooked-properties.php'], [
+			[
+				'Hooked properties cannot be static.',
+				7,
+			],
+			[
+				'Hooked properties cannot be static.',
+				15,
+			],
+		]);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Properties/data/static-hooked-properties.php b/tests/PHPStan/Rules/Properties/data/static-hooked-properties.php
new file mode 100644
index 0000000000..101f4b3b28
--- /dev/null
+++ b/tests/PHPStan/Rules/Properties/data/static-hooked-properties.php
@@ -0,0 +1,18 @@
+<?php declare(strict_types=1);
+
+namespace StaticHookedProperties;
+
+class HelloWorld
+{
+	public static string $foo {
+		get => $this->foo;
+		set => $this->foo = $value;
+	}
+}
+
+abstract class HiWorld
+{
+	public static string $foo {
+		get => 'dummy';
+	}
+}