Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve StreamSeekable's constructor arguments #62

Open
phrocker opened this issue May 12, 2020 · 0 comments
Open

Improve StreamSeekable's constructor arguments #62

phrocker opened this issue May 12, 2020 · 0 comments

Comments

@phrocker
Copy link
Owner

StreamSeekable constructors are confusing [1]. Since references are used, it implies that we're doing a copy constructor of objects. It would make more sense to either not pass by reference when using std::move(...) as this implies an r-value reference. Prefer to copy or change the constructor to NOT use references for moves.

Also would be a good opportunity to move away from header only to speed up builds.

[1] https://github.com/phrocker/sharkbite/blob/master/include/data/streaming/accumulo/StreamSeekable.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant