Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group assignment shows " HTML escaping when restoring from teleporter backup #2005

Closed
jamieburchell opened this issue Dec 14, 2021 · 1 comment

Comments

@jamieburchell
Copy link

jamieburchell commented Dec 14, 2021

Versions

  • Pi-hole version is v5.6 (Latest: v5.6)
  • AdminLTE version is v5.8 (Latest: v5.8)
  • FTL version is v5.11 (Latest: v5.11)

Platform

  • Raspbian GNU/Linux 11 (bullseye)
  • Raspberry Pi

Expected behavior

Group assignment drop down shows quotation marks instead of &quot ;

Actual behavior / bug

I restored a teleporter backup which included a group name of "No blocking". When this was restored, the group assignment drop down showed "No blocking".

After I resaved the group name as "No blocking", the drop down then showed this properly.

Steps to reproduce

Steps to reproduce the behavior:

  1. Create a group "No blocking"
  2. Assign it to a client
  3. Backup the configuration with teleporter
  4. Restore the configuration
  5. Look at the group assignment drop down for the client

Debug Token

Screenshots

Capture

Additional context

N/A

@yubiuser
Copy link
Member

Thanks for your report. This is bacially a duplicate of #1928, even when it occurs at a different place.
The whole XSS prevention and encoding/decoding needs a proper re-write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants