Skip to content

Commit dfd0125

Browse files
authored
Fix release workflow (#516)
## Problem When I tried releasing to prod, the workflow failed with the following error: ``` [Invalid workflow file: .github/workflows/release-prod.yaml#L26](https://github.com/pinecone-io/pinecone-python-client/actions/runs/15689847725/workflow) The workflow is not valid. .github/workflows/release-prod.yaml (Line: 26, Col: 11): Input python_versions_json is required, but not provided while calling. ``` ## Solution Recently, the unit and integration tests workflows were updated in this pr for creating a new project for each test run. These workflows are used in release-prod.yaml but the corresponding changes were not made. As a part of this PR, I have: 1. added `python_versions_json` for running unit-tests (required by [test-unit.yaml](https://github.com/pinecone-io/pinecone-python-client/pull/506/files#diff-470b33906ddc2d9d1d4ef14595bfb97dabdc66146282122f5f8109e77a00f1eaR5)) 2. added `encrypted_project_api_key` and `python_versions_json` for running integration tests (required by [test-integration.yaml](https://github.com/pinecone-io/pinecone-python-client/pull/506/files#diff-3aae3c6c7bf80d1ee8f43fe2844445abb98c3792ed1da99ef5fff84ce330e549R5)) 3. Added create-project and cleanup-project as extra steps (based on [this pr](#506)) ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [X] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan NA
1 parent 8553b93 commit dfd0125

File tree

1 file changed

+37
-3
lines changed

1 file changed

+37
-3
lines changed

.github/workflows/release-prod.yaml

Lines changed: 37 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,34 @@ jobs:
2525
unit-tests:
2626
uses: './.github/workflows/testing-unit.yaml'
2727
secrets: inherit
28+
with:
29+
python_versions_json: '["3.9"]'
30+
31+
create-project:
32+
uses: './.github/workflows/project-setup.yaml'
33+
secrets: inherit
34+
needs:
35+
- unit-tests
36+
2837
integration-tests:
29-
uses: './.github/workflows/testing-integration.yaml'
30-
secrets: inherit
38+
uses: './.github/workflows/testing-integration.yaml'
39+
secrets: inherit
40+
needs:
41+
- unit-tests
42+
- create-project
43+
with:
44+
encrypted_project_api_key: ${{ needs.create-project.outputs.encrypted_project_api_key }}
45+
python_versions_json: '["3.9", "3.13"]'
46+
3147
dependency-tests:
3248
uses: './.github/workflows/testing-dependency.yaml'
3349
secrets: inherit
34-
needs: unit-tests
50+
needs:
51+
- unit-tests
52+
- create-project
53+
with:
54+
encrypted_project_api_key: ${{ needs.create-project.outputs.encrypted_project_api_key }}
55+
3556
install-tests:
3657
uses: './.github/workflows/testing-install.yaml'
3758
secrets: inherit
@@ -58,3 +79,16 @@ jobs:
5879
secrets: inherit
5980
needs:
6081
- pypi
82+
83+
cleanup-project:
84+
if: ${{ always() }}
85+
needs:
86+
- create-project
87+
- integration-tests
88+
- pypi
89+
- docs-publish
90+
uses: './.github/workflows/project-cleanup.yaml'
91+
secrets: inherit
92+
with:
93+
project_id: ${{ needs.create-project.outputs.project_id }}
94+
encrypted_project_api_key: ${{ needs.create-project.outputs.encrypted_project_api_key }}

0 commit comments

Comments
 (0)