test/syncfalse.test.js test failure

[pacostas]

Description

The below error appears after running the tests on centos 9 and rhel9 with node 22. There is no error with node 20 on the centos 9 and in rhel9, so this error has a lot of chances of being related to the node version in combination with the platform.

 FAIL ​ test/syncfalse.test.js
#8 32.58  ✖ should be equal
#8 32.58 
#8 32.58   test/syncfalse.test.js
#8 32.58   63 |   await sleep(100)
#8 32.58   64 |   equal(actual, expected)
#8 32.58 > 65 |   equal(actual2.trim(), expected2)
#8 32.58      | --^
#8 32.58   66 |
#8 32.58   67 |   teardown(() => {
#8 32.58   68 |     os.hostname = hostname
#8 32.58 
#8 32.58   test: test/syncfalse.test.js asynchronous logging
#8 32.58   found: ""
#8 32.58   wanted: '{"level":30,"time":1459875739796,"pid":123456,"hostname":"abcdefghijk
#8 32.58 lmnopqr","msg":"h"}'
#8 32.58   compare: ===
#8 32.58   stack: |
#8 32.58     Test.<anonymous> (test/syncfalse.test.js:65:3)

Steps to reproduce:

1. create below docker file

cat <<EOF > containerfile.c9s
FROM quay.io/sclorg/nodejs-22-c9s

WORKDIR /usr/src/app

RUN git clone https://github.com/pinojs/pino.git
RUN cd pino && npm i --ignore-scripts
RUN cd pino && npm run test-ci
EOF

2. build dockerfile

docker build . -f ./containerfile.c9s

[mcollina]

Would you like to send a PR?

I think the solution is to increase that timer above that line.

[pacostas]

I tried increasing it to await sleep(100000) but the error still occurs

[mcollina]

I'm not really sure how to handle this, as I'm not really a RedHat user, but I think this should be solved - and I have no real time to dedicate here.

A PR that fixes this would be highly welcomed.

[pacostas]

Changed the line 56 on pino/test/syncfalse.test.js from silent:true to silent:false and got a little bit more additional output for the error as shown below:

So the test now fails before line 65 (where the comparison takes place).

Seems like a type error, as by running it with node instead of using tap --ts, the test do not fail.

 ✖ Cannot read properties of null (reading 'pipe')

  test/syncfalse.test.js                                                                   
  55 |                                                                                     
  56 |   const child = fork(join(__dirname, '/fixtures/syncfalse.js'), { silent: false })  
> 57 |   child.stdout.pipe(writer((s, enc, cb) => {                                          
     | ---------------^                                                                    
  58 |     actual2 += s                                                                    
  59 |     cb()                                                                            
  60 |   }))                                                                               

  test: asynchronous logging
  stack: |
    Test.<anonymous> (test/syncfalse.test.js:57:16)
  type: TypeError
  tapCaught: returnedPromiseRejection

Tried to fix it but, I always get the same error no matter what kind of function I set on the child.stdout.pipe function.