Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S2 Hyperdrive refuelling keeps adding up to the weight of hyperdrive equipment and ship total. #6089

Closed
Azdkns opened this issue Mar 13, 2025 · 8 comments

Comments

@Azdkns
Copy link

Azdkns commented Mar 13, 2025

Observed behaviour

When i refuell my Hyperdrive to travel in hyperspace, the weight of the fuel is added up to the weight of the hyperdrive equipment and to the weight of the ship. The increased weight of the ship makes it to have slower acceleration and travel time between in system stations as if a larger ship. Observed on S2 and S3 hyperdrives.

Expected behaviour

When i hyperspace and use the fuel of the hyperdrive, the weight of the equipment should be decreased.

Steps to reproduce

Multiple hyperspace jumps with refuelling.

Workaround
Buy a new S2 Hyperdrive.

My pioneer version (and OS):
20250302 (586b518master)
Fedora 41 workstation

Screenshots
Image
Image

@pebblegarden
Copy link

This weight issue also affects my bug 6090

@luchr
Copy link

luchr commented Mar 20, 2025

Does somebody know a workaround with the Lua console?

If I try:

player = require"Game".player
player:GetInstalledHyperdrive().mass = 12
player:UpdateEquipStats()

the (equipment-)mass of the Hyperdrive changes, but not the "All-up weight" (see ship stats) of the ship ...

@sturnclaw
Copy link
Member

I am not able to reproduce this bug on current master. A savefile before and after a hyperjump which demonstrates this bug is needed to be able to determine its cause.

Additionally, you should provide your output.txt from after the hyperjump was made.

@luchr
Copy link

luchr commented Mar 22, 2025

I see the same effects. Here are my two savefiles (one direct before and one direct after a hyperjump).

  • Before: 4t (hyper-)fuel + 4t mass of hyperdrive: 8t Hyper-equipment; Total weight: 252t
  • After: 1.2t (hyper-)fuel + 4t mass of hyperdrive: 8t(??) Hyper-equipment; Total weight: 252t

The Hyper-fuel left the tank but the mass stays in the hyperdrive ?!

Files:

Some screenshots:

Before: Hyperfuel: 4t
Image

Before: Hyper-Equipment: 8t
Image

Before: Total weight: 252t
Image

After: Hyperfuel: 1.2t
Image

After: Hyper-Equipment: 8t
Image

After: Total weight: 252t
Image

The stderr-output was

Info: DEBUG: Jumps since warranty: 0
Warranty expires: 22:09:54 11 Dec 3231
Info: TradeShips: Removed 0 ships before serialization
Info: Stars picked from galaxy: 41248
Info: Generating 83752 random stars
Info: Final stars number: 125000
Info: Screenshot screenshots/screenshot-20250322-031922.png saved
Info: Screenshot screenshots/screenshot-20250322-031928.png saved
Info: Screenshot screenshots/screenshot-20250322-031948.png saved
Info: StarSystemCache: misses: 66, slave hits: 0, master hits: 111800
Info: SectorCache: misses: 342, slave hits: 1180987, master hits: 1567491
Info: Creating new galaxy generator 'legacy' version 1
Info: Clearing and re-using previous Galaxy object
Info: StarSystemCache: misses: 0, slave hits: 0, master hits: 0
Info: SectorCache: misses: 0, slave hits: 0, master hits: 0
Info: Stars picked from galaxy: 41200
Info: Generating 83800 random stars
Info: Final stars number: 125000
Info: validation INFO [ships/xylophis.json]: Slot hyperdrive has no default hyperdrive equipment and will not have a hyperdrive when purchased.

@Azdkns
Copy link
Author

Azdkns commented Mar 22, 2025

To add to luchr comment,
Proper-more debug data files...

output.txt:

output.txt

Save files before, after:

Hyperdr__00_AFTER.txt
Hyperdr__00_BEFORE.txt

  • I renamed save files, to .txt, to be able to upload....

@sturnclaw
Copy link
Member

I am completely unable to reproduce this on latest master, even with the provided savefiles. Please try installing a build from a recent CI run, e.g. this one and make sure you're doing a clean install (i.e. remove all old game files before installing the new version).

If you're still able to reproduce the above behavior on that build, I'm a bit stumped as to what's responsible.

@luchr
Copy link

luchr commented Mar 23, 2025

For me the problem does not occur in the master version f4c096f.

Update:
My guess is: It was fixed with this commit db5330e. See, Types.lua, SetFuel

@sturnclaw
Copy link
Member

Indeed it was - thanks for confirming! Closing this issue as resolved; we'll be publishing a hotfix release at some point soon with the accumulated fixes in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants