Rails 3 compatibility?

[key88sf]

Currently there seem to be a few problems when using Jelly with Rails 3:

• rails generate jelly is unrecognized during install (had to copy the files manually)
• I get the following warning when including the jelly javascript_include_tag:
  DEPRECATION WARNING: RAILS_ROOT is deprecated. Please use ::Rails.root.to_s

[key88sf]

So all that's really needed is to change jelly_controller.rb:

def jelly_callback_erb_template
"<%=raw instance_eval(&@jelly_block).to_json %>" # added the 'raw' to this line
end

[TheGameKnave]

Would also love to see this updated. I applied the fix to a fork, but am still getting

uninitialized constant JellyHelper::RAILS_ROOT

I fell in love with jelly at my last job and would like to keep using it going forward.

[key88sf]

You need to change the instances of RAILS_ROOT to Rails.root in the jelly_controller.rb and any other files which have it.

[TheGameKnave]

ah, ok. I've done that, and the error has vanished, but there are 2 outstanding issues.

the first is a minor one, but in rails >= 3.1, js files like this should be served from vendor/assets/javascripts, not from the public file.

the second issue is that spread_jelly is dumping its contents into the body, and not the head, though it's sitting right next to the jellu js include tag. super weird.

[key88sf]

Just put the jelly .js files into vendor/assets/javascripts and they will be served via the asset pipeline :)

[TheGameKnave]

Tried that. No include. They had to be explicitly included in application.js, which worked, but I wasn't sure if anything else magical happened with the = javascript_include_tag :jelly, *application_jelly_files

the second problem is more of an issue, as the jelly tags are being dumped into the body of the document, and aren't evaluated from there. ;)

[key88sf]

Are you sure you added the "raw" change listed above, so they aren't getting HTML escaped?

[TheGameKnave]

dead sure. then I added a space after the equals sign, as that's the convention I've seen for raw (i'm a little noobish). most recently, I replaced the raw with a .html_safe at the end of the string, but to no avail. it's still coming out like this:

  <script src="/assets/jelly.js" type="text/javascript"></script>
          &lt;script type=&quot;text/javascript&quot;&gt;
    //&lt;![CDATA[
....

I'm wondering if it might have something to do with the actual spread_jelly method, as it says:

<<-HTML
  #{window_token_javascript_tag}
  #{attach_javascript_component_javascript_tag(jelly_attachments)}
HTML

but I'm not sure if this method of string interpolation is considered valid in later versions of ruby. it's impossible to find out by googling "ruby html". ;)

[TheGameKnave]

ok, that was it for this issue. I removed the HTML brackets and changed the bracketed code above to:

window_token_javascript_tag.html_safe
attach_javascript_component_javascript_tag(jelly_attachments).html_safe

however, it looks like only the last line is printing. the token isn't coming through, though everything seems to function correctly. I don't know how crucial the token is if i'm already calling it with csrf_meta_tags, but I thought it best to not go removing things I don't understand. ;)

I finally just ended up escaping the spread_jelly method when I call it. works a treat for now.

Also, I had to include the jelly js files before anything that invoked them. Probably another newb mistake, but I seem to have gotten it working now. thanks so much for your help! (i ended up putting them back in the vendor folder and including them explicitly)

Anyone from google or wherever reading this, the version that I've forked seems to work in rails 3.2.2, ruby 1.9.3p125, but you have to html_safe the spread_jelly method when you call it, for now.

further notes: I was unable to add config.gem 'jelly' to environment.rb; that file has a different purpose now, so I added it to application.rb, then i tried removing it and everything works fine, so i don't know what it does. ehehe.