-
Notifications
You must be signed in to change notification settings - Fork 462
Add JAV support to backoffice #10669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@asmecher I have added new PRs for that, incorporating the review comments fixes of #10666. There are some more changes that we need to consider like tests fixes and OMP, OPS changes. Also I have added a check for Nevertheless, the other indented functionality is in place. @ewhanson This line of code:
is changed to that
The |
Hey @defstat, the |
@ewhanson thanks! So that means that if we now distinguish the versions by a respective string instead of an integer, the current functionality will still work as it supposed to? |
@defstat, yes it should. 🤞 Though it should be tested in OPS with DOI versioning enabled to make sure. The Cypress tests there will likely need to be updated as well. |
@asmecher the PRs are ready for another review round. |
@defstat, with apologies for the delay, I've added some reviews:
Thanks! |
@asmecher I have resolved the review comments. The code is ready for another review. OMP, OPS porting is pending, as well as the changes for Native Import/Export plugin for the newly created |
Uh oh!
There was an error while loading. Please reload this page.
Describe the feature
The following changes should be addressed in this submodule:
-- Get next available version numbering for submission
-- Update JAV stage and version numbering for publication
version
column frompublications
and migratePRs
OJS: pkp/ojs#4604
OMP: pkp/omp#1978
OPS: pkp/ops#971
PKP-LIB: #10810
UI-LIBRARY: pkp/ui-library#488
The text was updated successfully, but these errors were encountered: