-
Notifications
You must be signed in to change notification settings - Fork 462
Add ReCAPTCHA support to password reset form #6984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Since ReCAPTCHA is not available in China, can/should we do some basic rate limiting? If we log the reset request, we should be able to not send another reset request until the last one expires? |
As mentioned on Slack channel, we could use the hCaptcha instead reCaptcha. |
Just wanted to add a +1 for rate limiting the password reset form. |
+1 |
@asmecher This feature its on dev roadmap? If not, I will spend some time creating this as a package. |
@henriqueramos, it hasn't yet been prioritized against a specific release, but I'd be happy to get a pull request reviewed! |
Hello @asmecher! Hope you're doing well. I just created two PRs that are related to this issue. If you want to take a look or assign someone to make the code reviews, I would appreciate that! |
Looks good, @Godoy0722; can you forward-port this to |
Hello Alec! I'll work on it and ping you in the other PRs as soon as possible. I'll also link the PRs that I create with this one. |
Hi there @asmecher! Just a heads-up that I make the forward port for this issue on all OJS versions ahead of the 3.3 one, in case you want to take a better look at them! If there's anything else you need me to do about this issue, please don't hesitate to contact me! Thank you so much, Alec! |
Hi @asmecher! Would it be possible to add this fix to version 3.3.0-21? |
If we're implementing this, then I think it makes sense to also bring the #6539 to 3.3 |
@Godoy0722, could you list out all the PRs here in a comment? That'll make sure I don't miss anything. Thanks! |
@Godoy0722, with apologies for the delay, there's just one small comment on the 3.3.0 review that needs attention, then it's all ready! |
The password reset form can generate unwanted emails if abused. Add ReCAPTCHA support to the password reset form.
The text was updated successfully, but these errors were encountered: