pkp/pkp-lib#9295 publishing without issue assignment in editorial workflow (#619)

pkp/pkp-lib#9295 remove context level settings named continuousPublication

pkp/pkp-lib#9295 code cleanup

pkp/pkp-lib#9295 fixed issue change glitch

pkp/pkp-lib#9295 removed unnecessary comment

pkp/pkp-lib#9295 optimize for issue less context

pkp/pkp-lib#9295 repplace setting continuousPublication with first class column published

pkp/pkp-lib#9295 publish execution order update

pkp/pkp-lib#9295 published logic check added

pkp/pkp-lib#9295 better state handing before publication publish or schedule

Author: touhidurabir

src/components/Form/fields/FieldSelectIssue.vue

@@ -164,10 +164,10 @@ export default {
 				'@/pages/workflow/workflowStore.js'
 			);
 
-			const workflowSotre = useWorkflowStore();
+			const workflowStore = useWorkflowStore();
 
-			workflowSotre.workflowAssignToIssue({}, (finishedData) => {
-				if (finishedData.data.issueId) {
+			workflowStore.workflowAssignToIssue({}, (finishedData) => {
+				if (finishedData.data) {
 					this.currentValue = finishedData.data.issueId;
 				}
 			});

src/pages/workflow/composables/useWorkflowActions.js

@@ -101,7 +101,7 @@ export function useWorkflowActions() {
 	}
 
 	function workflowAssignToIssueAndScheduleForPublication(
-		{selectedPublication, submission},
+		{pageInitConfig, selectedPublication, submission},
 		finishedCallback,
 	) {
 		// if version is unassigned, we need to assign it to a publication stage first
@@ -110,13 +110,40 @@ export function useWorkflowActions() {
 				{selectedPublication, submission},
 				(publicationData) =>
 					workflowAssignToIssueAndScheduleForPublication(
-						{submission, selectedPublication: publicationData},
+						{pageInitConfig, selectedPublication: publicationData, submission},
 						finishedCallback,
 					),
 			);
 		}
 
-		if (selectedPublication.issueId === null) {
+		// if there are no issues, we can schedule the publication immediately
+		if (pageInitConfig.publicationSettings.countIssues === 0) {
+			workflowScheduleForPublication(
+				{submission, selectedPublication},
+				finishedCallback,
+			);
+
+			return;
+		}
+
+		// If the publication is marked as published,
+		// and not assigned to an issue, or assigned to an issue that is not published (e.g. future issue),
+		// we can publish the publication immediately as issueless or continuous publication
+		if (
+			selectedPublication.published &&
+			(selectedPublication.issueId === null ||
+				!pageInitConfig.publicationSettings.issuePublishedStatus[
+					selectedPublication.issueId
+				])
+		) {
+			workflowScheduleForPublication(
+				{submission, selectedPublication},
+				finishedCallback,
+			);
+			return;
+		}
+
+		if (selectedPublication.issueId === null || selectedPublication.published) {
 			const {url} = useLegacyGridUrl({
 				component: 'modals.publish.AssignToIssueHandler',
 				op: 'assign',
@@ -138,7 +165,7 @@ export function useWorkflowActions() {
 				},
 				{
 					onClose: async ({formId, data}) => {
-						if (data?.issueId) {
+						if (data?.issueId || data?.published) {
 							workflowScheduleForPublication(
 								{submission, selectedPublication},
 								finishedCallback,

src/pages/workflow/workflowStore.js

@@ -157,6 +157,7 @@ export const useWorkflowStore = defineComponentStore(
 						submission: submission.value,
 						selectedPublication: selectedPublication.value,
 						reviewRoundId: selectedReviewRound.value?.id,
+						pageInitConfig: props.pageInitConfig,
 						store,
 					},
 					(finishedData) => {