Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev instructions don't work #2

Open
m-mohr opened this issue Jun 5, 2023 · 2 comments
Open

Dev instructions don't work #2

m-mohr opened this issue Jun 5, 2023 · 2 comments

Comments

@m-mohr
Copy link
Contributor

m-mohr commented Jun 5, 2023

The dev instructions don't work for me, I assume it's because the go-stac package is not available for the public.

When running e.g. make format, I get:

$ make format
Unable to find image 'us.gcr.io/planet-gcr/go-stac:v0.22.0' locally
docker: Error response from daemon: unauthorized: You don't have the needed permissions to perform this operation, and you may have invalid credentials. To authenticate your request, follow the steps in: https://cloud.google.com/container-registry/docs/advanced-authentication.
See 'docker run --help'.
make: *** [Makefile:39: format] Error 125

I also can't access https://us.gcr.io/planet-gcr/go-stac even when authenticated with my (non-Planet) Google account, so I assume configuring credentials as indicated in the documentation won't help.

@tschaub
Copy link
Member

tschaub commented Jun 6, 2023

I'm waiting on a request to change the visibility of that image. In the meantime, we could update the instructions to suggest installing the go-stac CLI, or you could just skip those steps.

The CI job should catch any JSON schema validation issues. And the stats are updated as part of the publish step - so not strictly necessary to have them updated in the source.

Since there will be some intermediate steps between merging in a contribution and publishing the resources, we can make any necessary changes before publishing. So I think it makes sense for you to just skip the suggested make tasks.

@m-mohr
Copy link
Contributor Author

m-mohr commented Jun 6, 2023

Thanks! Okay, I'll just create PRs and you can run the scripts before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants