Skip to content

Commit be50c3a

Browse files
authored
Merge pull request #1082 from planetlabs/hw/reorder_list_kwargs
Reorder list kwargs to maintain consistency between releases
2 parents f14f50a + a428549 commit be50c3a

File tree

3 files changed

+27
-24
lines changed

3 files changed

+27
-24
lines changed

CHANGES.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
2.12.0 (2024-12-06)
2-
- Add parameters to the subscriptions list command: --created, --start-time,
1+
2.12.0 (2024-12-09)
2+
- Add parameters to the subscriptions list command: --source-type, --created, --start-time,
33
--end-time, --updated, --hosting, --name, --name-contains, and --sort-by.
44
- Add parameters to the orders list command: --source-type, --name,
55
--name-contains, --created-on, --last-modified, --hosting, and --sort-by.
6+
- Remove the unused limit parameter of SubscriptionsClient.get_results_csv
67

78
2.11.0 (2024-10-21)
89

planet/clients/orders.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -462,16 +462,17 @@ async def wait(self,
462462

463463
return current_state
464464

465-
async def list_orders(self,
466-
state: Optional[str] = None,
467-
source_type: Optional[str] = None,
468-
name: Optional[str] = None,
469-
name__contains: Optional[str] = None,
470-
created_on: Optional[str] = None,
471-
last_modified: Optional[str] = None,
472-
hosting: Optional[bool] = None,
473-
sort_by: Optional[str] = None,
474-
limit: int = 100) -> AsyncIterator[dict]:
465+
async def list_orders(
466+
self,
467+
state: Optional[str] = None,
468+
limit: int = 100,
469+
source_type: Optional[str] = None,
470+
name: Optional[str] = None,
471+
name__contains: Optional[str] = None,
472+
created_on: Optional[str] = None,
473+
last_modified: Optional[str] = None,
474+
hosting: Optional[bool] = None,
475+
sort_by: Optional[str] = None) -> AsyncIterator[dict]:
475476
"""Iterate over the list of stored orders.
476477
477478
By default, order descriptions are sorted by creation date with the last created

planet/clients/subscriptions.py

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -59,18 +59,19 @@ def __init__(self,
5959
if self._base_url.endswith('/'):
6060
self._base_url = self._base_url[:-1]
6161

62-
async def list_subscriptions(self,
63-
created: Optional[str] = None,
64-
end_time: Optional[str] = None,
65-
hosting: Optional[bool] = None,
66-
name__contains: Optional[str] = None,
67-
name: Optional[str] = None,
68-
source_type: Optional[str] = None,
69-
start_time: Optional[str] = None,
70-
status: Optional[Sequence[str]] = None,
71-
sort_by: Optional[str] = None,
72-
updated: Optional[str] = None,
73-
limit: int = 100) -> AsyncIterator[dict]:
62+
async def list_subscriptions(
63+
self,
64+
status: Optional[Sequence[str]] = None,
65+
limit: int = 100,
66+
created: Optional[str] = None,
67+
end_time: Optional[str] = None,
68+
hosting: Optional[bool] = None,
69+
name__contains: Optional[str] = None,
70+
name: Optional[str] = None,
71+
source_type: Optional[str] = None,
72+
start_time: Optional[str] = None,
73+
sort_by: Optional[str] = None,
74+
updated: Optional[str] = None) -> AsyncIterator[dict]:
7475
"""Iterate over list of account subscriptions with optional filtering and sorting.
7576
7677
Note:

0 commit comments

Comments
 (0)