Skip to content

Consistent use / docs of dash #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cholmes opened this issue Jul 20, 2022 · 0 comments
Closed

Consistent use / docs of dash #644

cholmes opened this issue Jul 20, 2022 · 0 comments

Comments

@cholmes
Copy link
Member

cholmes commented Jul 20, 2022

First off, I learned a lot reading through this. Thank you for putting together such a concise and helpful guide. I did notice that our story on the - input is inconsistent. I would like to see if we can get more consistent. Right now I am pretty sure the dash is not required for any required arguments that are JSON. so e.g. orders create doesn't require the dash (ref). data search ([ref](@click.argument("filter", type=types.JSON(), default="-", required=False))) and data search-create don't require the dash either.

Originally posted by @jreiberkyle in #642 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants