Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple for more fields #30

Open
platelminto opened this issue Mar 11, 2021 · 0 comments
Open

Allow multiple for more fields #30

platelminto opened this issue Mar 11, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@platelminto
Copy link
Owner

Some fields could have multiple matches, and currently just throw away the others (e.g. audio, quality). They should give all of them, and become just list types.

This could be done by, rather than just ignoring and adding the match indices when the given field already exists, check if it's a significant other one (i.e. not just because the regex for one also matches another, which currently makes the order of regexes for each field in patterns.py important - would be nice to make the order not matter), and if yes add it.

This opens up the possibility of generalising list types, rather than the current custom regexes and methods that fields like genre, language, etc. must have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant