-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parsing non-english chars along with english title & More language patterns #66
base: dev
Are you sure you want to change the base?
Conversation
2.6
The commits messages are from previous. Please discard those and squash it when merge. |
Its been a while. Any plan for merging this @platelminto. I'm planning to add more changes. |
Hey, sorry for taking a while to look at this. I've tried to keep this library source-compatible with Python 2.7 & 3.5 - many of the things you've added explicitly (or implicitly) change things that would make Python 3.7 the minimum supported version. From what I can see, this is mostly to handle non-English character-sets more easily. You've done a lot with this PR - including a lot of code clean-up that, honestly, I would never have gotten to. Thanks a lot for that! If you think it's too much of a hassle to change things to remain compatible with Python 2.7, I will happily make this library Python 3.7+, and accept this PR (after I review all changes in more detail). If you think you can still change things to remain 2.7-compatible, that'd be amazing, but otherwise I'm happy to move on. Let me know what you think. |
Im not sure if anyone using python2 for new development. But its up to you. Btw i have moved to another torrent parsing library since you're not active on this. |
Ah fair enough, thanks :) |
Inspired by https://github.com/TheBeastLT/parse-torrent-title/blob/master/src/parser.js#L74-L94
Resolved #64