don't check object pointer before deleting /Markus Elfring

Author: Hieu Hoang

mert/FeatureStats.cpp

@@ -181,10 +181,8 @@ FeatureStats::FeatureStats(const size_t size)
 
 FeatureStats::~FeatureStats()
 {
-  if (m_array) {
-    delete [] m_array;
-    m_array = NULL;
-  }
+  delete [] m_array;
+  m_array = NULL;
 }
 
 void FeatureStats::Copy(const FeatureStats &stats)

mert/ScoreStats.cpp

@@ -35,10 +35,8 @@ ScoreStats::ScoreStats(const size_t size)
 
 ScoreStats::~ScoreStats()
 {
-  if (m_array) {
-    delete [] m_array;
-    m_array = NULL;
-  }
+  delete [] m_array;
+  m_array = NULL;
 }
 
 void ScoreStats::Copy(const ScoreStats &stats)
@@ -157,4 +155,4 @@ bool operator==(const ScoreStats& s1, const ScoreStats& s2)
   return true;
 }
 
-}
+}

mert/Singleton.h

@@ -21,10 +21,8 @@ class Singleton
   }
 
   static void Delete() {
-    if (m_instance) {
-      delete m_instance;
-      m_instance = NULL;
-    }
+    delete m_instance;
+    m_instance = NULL;
   }
 
 private:

moses/FF/LexicalReordering/LexicalReordering.cpp

@@ -52,8 +52,7 @@ LexicalReordering::LexicalReordering(const std::string &line)
 
 LexicalReordering::~LexicalReordering()
 {
-  if(m_table)
-    delete m_table;
+  delete m_table;
   delete m_configuration;
 }
 

moses/TranslationModel/DynSAInclude/onlineRLM.h

@@ -43,10 +43,10 @@ class OnlineRLM: public PerfectHash<T>
       alpha_[i] = i * log10(0.4);
   }
   ~OnlineRLM() {
-    if(alpha_) delete[] alpha_;
+    delete[] alpha_;
     if(bAdapting_) delete vocab_;
     else vocab_ = NULL;
-    if(cache_) delete cache_;
+    delete cache_;
     delete bPrefix_;
     delete bHit_;
   }