Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job readme-link-check failing #6794

Closed
wesleybl opened this issue Feb 28, 2025 · 3 comments
Closed

Job readme-link-check failing #6794

wesleybl opened this issue Feb 28, 2025 · 3 comments
Labels
01 type: bug 30 needs: triage New issue that needs confirmation before work begins

Comments

@wesleybl
Copy link
Member

The readme-link-check job is failing. It seems that two sites are having problems:

https://www.centraalmuseum.nl/nl
https://www.cmscom.jp

It seems that one is having an error and the other is taking a long time to respond. See:

https://github.com/plone/volto/actions/runs/13588143443/job/37987643323?pr=6754

What should I do in this situation? Remove the links from the code? Whitelist them?

@wesleybl wesleybl added 01 type: bug 30 needs: triage New issue that needs confirmation before work begins labels Feb 28, 2025
@wesleybl
Copy link
Member Author

Hi @terapyon! I saw that you were the one who put the site https://www.cmscom.jp in the Readme. Is it no longer online?

stevepiercy added a commit to collective/awesome-volto that referenced this issue Feb 28, 2025
@terapyon these two sites have repeatedly failed. They cause the README linkcheck to fail in Volto. See plone/volto#6794

Please let us know.

```
504 ERROR
The request could not be satisfied.
CloudFront attempted to establish a connection with the origin, but either the attempt failed or the origin closed the connection. We can't connect to the server for this app or website at this time. There might be too much traffic or a configuration error. Try again later, or contact the app or website owner.
If you provide content to customers through CloudFront, you can find steps to troubleshoot and help prevent this error by reviewing the CloudFront documentation.

Generated by cloudfront (CloudFront)
Request ID: Q9EsRsoFe9fBdPSgG6ez1bMV1Ez_7j9q8bsmqHiTV-H4F6NVn89iVA==
```
@stevepiercy
Copy link
Collaborator

These two sites have a history of being unreliable. I've previously contacted the maintainers and reopened an earlier PR collective/awesome-volto#27. @jasperkennis would you please investigate your site?

I also opened a PR for @terapyon's sites. collective/awesome-volto#30

@wesleybl we should whitelist only sites that are maintained by the Plone organization. All others may be removed. I'd say three strikes, you're out, but that's not my call alone. We can track it by how many times we create, close, and reopen a PR.

We should first create a PR in https://github.com/collective/awesome-volto/ to remove the unreliable site, and there contact the maintainers of the third party site, If they don't respond or the site fails too many times, then we should merge the PR and remove the site.

The whole reason to have a README linkcheck is to promote Plone sites. If they're not reliable, then we should not promote them, as it makes Plone look unreliable.

@wesleybl
Copy link
Member Author

wesleybl commented Mar 5, 2025

The sites are back to normal.

@wesleybl wesleybl closed this as completed Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 type: bug 30 needs: triage New issue that needs confirmation before work begins
Projects
None yet
Development

No branches or pull requests

2 participants