Skip to content

Import some choreographer stuff into kaleido for convenience #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ayjayt opened this issue Mar 25, 2025 · 0 comments · Fixed by #312
Closed

Import some choreographer stuff into kaleido for convenience #307

ayjayt opened this issue Mar 25, 2025 · 0 comments · Fixed by #312
Assignees
Labels
P1 needs immediate attention

Comments

@ayjayt
Copy link
Collaborator

ayjayt commented Mar 25, 2025

From @emilykl

There’s a few classes/functions that would be nice to be able to import from Kaleido directly rather than Choreographer — I’d like access to them for the Plotly.py integration but don’t really want to import choreographer :
    choreographer.ChromeNotFoundError — so that we can catch the error on figure generation and display an error message that comes from Plotly rather than Kaleido
    choreographer.cli._cli_utils.get_chrome_download_path() — so that we can display the installation path to the user before performing the Chrome install. In addition that function seems like an internal function, would nice to make it part of the official API.
@ayjayt ayjayt self-assigned this Mar 25, 2025
@ayjayt ayjayt added the P1 needs immediate attention label Mar 25, 2025
@ayjayt ayjayt linked a pull request Mar 25, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 needs immediate attention
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant