Skip to content

Commit f1692f3

Browse files
committed
Adding correct docs in README.md refs to PlotlyViaCDNModule. Closes #129
1 parent c3e6263 commit f1692f3

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

Diff for: README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,8 @@ import { CommonModule } from '@angular/common';
190190
import { PlotlyViaCDNModule } from 'angular-plotly.js';
191191

192192

193-
PlotlyViaCDNModule.plotlyVersion = '1.49.4'; // can be `latest` or any version number (i.e.: '1.40.0')
194-
PlotlyViaCDNModule.plotlyBundle = 'basic'; // optional: can be null (for full) or 'basic', 'cartesian', 'geo', 'gl3d', 'gl2d', 'mapbox' or 'finance'
193+
PlotlyViaCDNModule.setPlotlyVersion('1.55.2'); // can be `latest` or any version number (i.e.: '1.40.0')
194+
PlotlyViaCDNModule.setPlotlyBundle('basic'); // optional: can be null (for full) or 'basic', 'cartesian', 'geo', 'gl3d', 'gl2d', 'mapbox' or 'finance'
195195

196196
@NgModule({
197197
imports: [

Diff for: package-lock.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: projects/plotly/src/lib/plotly-via-cdn.module.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export class PlotlyViaCDNModule {
2323
PlotlyService.setModuleName('ViaCDN');
2424
}
2525

26-
static setPlotlyVersion(version: string): void {
26+
public static setPlotlyVersion(version: string): void {
2727
const isOk = version === 'latest' || /^\d\.\d{1,2}\.\d{1,2}$/.test(version);
2828
if (!isOk) {
2929
throw new Error(`Invalid plotly version. Please set 'latest' or version number (i.e.: 1.4.3)`);
@@ -33,7 +33,7 @@ export class PlotlyViaCDNModule {
3333
PlotlyViaCDNModule.plotlyVersion = version;
3434
}
3535

36-
static setPlotlyBundle(bundle: PlotlyBundleName): void {
36+
public static setPlotlyBundle(bundle: PlotlyBundleName): void {
3737
const isOk = bundle === null || PlotlyViaCDNModule.plotlyBundleNames.indexOf(bundle) >= 0;
3838
if (!isOk) {
3939
const names = PlotlyViaCDNModule.plotlyBundleNames.map(n => `"${n}"`).join(', ');
@@ -43,7 +43,7 @@ export class PlotlyViaCDNModule {
4343
PlotlyViaCDNModule.plotlyBundle = bundle;
4444
}
4545

46-
static loadViaCDN(): void {
46+
public static loadViaCDN(): void {
4747
PlotlyService.setPlotly('waiting');
4848

4949
const init = () => {

Diff for: projects/plotly/src/lib/plotly.module.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { NgModule } from '@angular/core';
22
import { CommonModule } from '@angular/common';
33

44
import { PlotlyService } from './plotly.service';
5-
import { PlotlySharedModule } from './plotly-shared.module'
5+
import { PlotlySharedModule } from './plotly-shared.module';
66

77

88

0 commit comments

Comments
 (0)