Skip to content

Commit 2fdc603

Browse files
author
Xing Han Lu
authored
Merge pull request #589 from plotly/improve-circleci
Propose various improvement to circleci workflow Former-commit-id: 2f8ed51
2 parents 3959eb6 + 0a69c5f commit 2fdc603

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

.circleci/config.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,13 @@ jobs:
99
steps:
1010
- checkout
1111
- run:
12-
name: install black and flake8
12+
name: install black
1313
command: |
14-
sudo pip install black==19.10b0 flake8
14+
sudo pip install black==19.10b0
1515
- run:
1616
name: run black
1717
command: |
1818
black . --check
19-
- run:
20-
name: run flake8
21-
command: |
22-
flake8 --select=E265,E711,W291
2319
deploy_to_playground:
2420
docker:
2521
- image: circleci/python:3.6-stretch
@@ -106,7 +102,7 @@ jobs:
106102
107103
for APP in $APPS_MODIFIED
108104
do
109-
DASH_ENTERPRISE_URL="$DASH_GALLERY_ENTERPRISE_URL" DASH_ENTERPRISE_API_KEY="$DASH_GALLERY_ENTERPRISE_API_KEY" PATH="$HOME/bin:$PATH" ./deploy "$APP"
105+
CREATE_APP=true DASH_ENTERPRISE_URL="$DASH_GALLERY_ENTERPRISE_URL" DASH_ENTERPRISE_API_KEY="$DASH_GALLERY_ENTERPRISE_API_KEY" PATH="$HOME/bin:$PATH" ./deploy "$APP"
110106
done
111107
112108
workflows:

deploy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ main() {
9494
fi
9595

9696
if [[ ! -d "$app_dir/assets" ]]; then
97-
log-fail "App $APP is missing the assets directory"
97+
log-warn "App $APP is missing the assets directory. Make sure to create one if you use asset files."
9898
fi
9999

100100
log-header "Deploying $APP"
@@ -178,7 +178,7 @@ main() {
178178
log-info "Python app detected, injecting common python-specific files"
179179
cp -p -n "$SOURCE_DIR/app.json" "$tmp_full_clone/app.json"
180180
cp -p "$SOURCE_DIR/predeploy.py" "$tmp_full_clone/predeploy.py"
181-
test -f "$tmp_full_clone/runtime.txt" || cp -p "$SOURCE_DIR/runtime.txt" "$tmp_full_clone/runtime.txt"
181+
test -f "$tmp_full_clone/runtime.txt" || test -f "$SOURCE_DIR/runtime.txt" || cp -p "$SOURCE_DIR/runtime.txt" "$tmp_full_clone/runtime.txt"
182182
fi
183183

184184
set +e

0 commit comments

Comments
 (0)