From 5eca8c4000768eec9920e506fcec420280841dc0 Mon Sep 17 00:00:00 2001 From: philippe Date: Wed, 18 Jun 2025 12:06:57 -0400 Subject: [PATCH 1/2] fix closeOnSelect --- CHANGELOG.md | 2 +- .../dash-core-components/src/components/Dropdown.react.js | 4 ++-- .../dash-core-components/src/fragments/Dropdown.react.js | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7bff945c34..5ed315f9e8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,7 +17,7 @@ This project adheres to [Semantic Versioning](https://semver.org/). ## Added - [#3294](https://github.com/plotly/dash/pull/3294) Added the ability to pass `allow_optional` to Input and State to allow callbacks to work even if these components are not in the dash layout. - [#3077](https://github.com/plotly/dash/pull/3077) Add new parameter `assets_path_ignore` to `dash.Dash()`. Closes [#3076](https://github.com/plotly/dash/issues/3076) -- [#3202](https://github.com/plotly/dash/pull/3202) expose the closeMenuOnSelect option in dropdown component +- [#3202](https://github.com/plotly/dash/pull/3202) expose the closeOnSelect option in dropdown component ## Changed diff --git a/components/dash-core-components/src/components/Dropdown.react.js b/components/dash-core-components/src/components/Dropdown.react.js index f3576e6aab..6ff5bac387 100644 --- a/components/dash-core-components/src/components/Dropdown.react.js +++ b/components/dash-core-components/src/components/Dropdown.react.js @@ -148,7 +148,7 @@ Dropdown.propTypes = { /** * If false, the menu of the dropdown will not close once a value is selected. */ - closeMenuOnSelect: PropTypes.bool, + closeOnSelect: PropTypes.bool, /** * height of each option. Can be increased when label lengths would wrap around @@ -219,7 +219,7 @@ Dropdown.defaultProps = { searchable: true, optionHeight: 35, maxHeight: 200, - closeMenuOnSelect: true, + closeOnSelect: true, persisted_props: ['value'], persistence_type: 'local', }; diff --git a/components/dash-core-components/src/fragments/Dropdown.react.js b/components/dash-core-components/src/fragments/Dropdown.react.js index 3ec394a8bd..c79228fde9 100644 --- a/components/dash-core-components/src/fragments/Dropdown.react.js +++ b/components/dash-core-components/src/fragments/Dropdown.react.js @@ -33,7 +33,7 @@ const RDProps = [ 'maxHeight', 'style', 'className', - 'closeMenuOnSelect', + 'closeOnSelect', ]; const Dropdown = props => { From 6f6e16e610fa246c2c23b9022bc4274eda7f4f39 Mon Sep 17 00:00:00 2001 From: philippe Date: Wed, 18 Jun 2025 13:35:57 -0400 Subject: [PATCH 2/2] build