Skip to content

Commit 1e24ca0

Browse files
better tests
1 parent 458554a commit 1e24ca0

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

packages/python/plotly/plotly/io/_base_renderers.py

+2
Original file line numberDiff line numberDiff line change
@@ -679,6 +679,8 @@ def open_html_in_browser(html, using=None, new=0, autoraise=True):
679679
for browser_key in using:
680680
try:
681681
browser = webbrowser.get(browser_key)
682+
if browser is not None:
683+
break
682684
except webbrowser.Error:
683685
pass
684686

packages/python/plotly/plotly/tests/test_io/test_renderers.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -226,9 +226,8 @@ def test_browser_renderer_show(fig1, renderer):
226226
pio.renderers.default = renderer
227227
renderer_obj = pio.renderers[renderer]
228228
using = renderer_obj.using
229-
if isinstance(renderer_obj.using, tuple):
230-
using = renderer_obj.using[0]
231-
renderer_obj.using = using
229+
if not isinstance(renderer_obj.using, tuple):
230+
using = (using,)
232231

233232
# Setup mocks
234233
mock_get = MagicMock(name="test get")
@@ -253,7 +252,7 @@ def open_url(url, new=0, autoraise=True):
253252
pio.show(fig1)
254253

255254
# check get args
256-
mock_get.assert_called_once_with(using)
255+
mock_get.assert_any_call(using[0])
257256

258257
# check open args
259258
mock_call_args = mock_browser.open.call_args

0 commit comments

Comments
 (0)