Merge pull request #3891 from aksakalli/patch-1

gvwilson · web-flow · commit 7181c4dbdd86 · 2024-10-04T16:25:37.000-04:00
fix SyntaxWarning for comparing with a literal
diff --git a/packages/python/chart-studio/chart_studio/tools.py b/packages/python/chart-studio/chart_studio/tools.py
@@ -287,7 +287,7 @@ def _get_embed_url(file_owner_or_url, file_id=None):
             "The 'file_id' argument must be a non-negative number."
         )
 
-    if share_key is "":
+    if share_key == "":
         return "{plotly_rest_url}/~{file_owner}/{file_id}.embed".format(
             plotly_rest_url=plotly_rest_url, file_owner=file_owner, file_id=file_id
         )

Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,7 @@ def _get_embed_url(file_owner_or_url, file_id=None):`
`287`	`287`	`"The 'file_id' argument must be a non-negative number."`
`288`	`288`	`)`
`289`	`289`
`290`		`- if share_key is "":`
	`290`	`+ if share_key == "":`
`291`	`291`	`return "{plotly_rest_url}/~{file_owner}/{file_id}.embed".format(`
`292`	`292`	`plotly_rest_url=plotly_rest_url, file_owner=file_owner, file_id=file_id`
`293`	`293`	`)`