Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the exit mechanism of the pluto cli #251

Open
2 tasks
jianzs opened this issue Jun 13, 2024 · 0 comments
Open
2 tasks

Enhance the exit mechanism of the pluto cli #251

jianzs opened this issue Jun 13, 2024 · 0 comments
Labels
cli command-line interface enhancement New feature or request help wanted Extra attention is needed

Comments

@jianzs
Copy link
Contributor

jianzs commented Jun 13, 2024

Describe the feature

Currently, the pluto cli command is designed to require two presses of Ctrl-C to exit, as a measure to prevent accidental exits. However, the intended functionality is to pass the SIGINT signal to the simulator in order to initiate a graceful cleanup of resources. The first press of Ctrl-C is meant to be ignored by the cli and subsequently passed to the simulator. Upon receiving the signal, the simulator should perform a graceful cleanup. The second press of Ctrl-C should then be caught by the cli to exit the command line interface.

So, the current behavior is such that after the first press of Ctrl-C, the simulator exits. This is not the intuitive behavior that we expect.

What we expect are two possible behaviors:

  • Upon pressing Ctrl-C once, the simulator and cli should gracefully exit.
  • Alternatively, two presses of Ctrl-C should be required for the simulator to exit, ensuring that the application remains operational after the first press.

Use Case

pluto run

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@jianzs jianzs added enhancement New feature or request help wanted Extra attention is needed cli command-line interface labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli command-line interface enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant