Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Unirest config #421

Closed
kpe09 opened this issue Oct 7, 2024 · 0 comments · Fixed by #420
Closed

Issue with Unirest config #421

kpe09 opened this issue Oct 7, 2024 · 0 comments · Fixed by #420

Comments

@kpe09
Copy link
Contributor

kpe09 commented Oct 7, 2024

The Unirest configuration is applied every time an action is executed, meaning the configured default header is also being appended with every execution, because the Unirest client is a singleton. In projects with a high number of modules, this can lead to the header being too big and then causing a broken pipe. The fix is simple: the method addDefaultHeader(...) needs to be replaced with setDefaultHeader(...). I have already created a pull request with the necessary fix:
#420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant