Skip to content

Commit 13cb51b

Browse files
committed
Don't carelessly expose internal-use constant to the API
if we want to actually expose these, we should probably consider putting them in a separate class.
1 parent db49000 commit 13cb51b

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/Binary.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,13 @@
3939
use const PHP_INT_MAX;
4040

4141
class Binary{
42-
public const SIZEOF_BYTE = 1;
43-
public const SIZEOF_SHORT = 2;
44-
public const SIZEOF_INT = 4;
45-
public const SIZEOF_LONG = 8;
42+
private const SIZEOF_BYTE = 1;
43+
private const SIZEOF_SHORT = 2;
44+
private const SIZEOF_INT = 4;
45+
private const SIZEOF_LONG = 8;
4646

47-
public const SIZEOF_FLOAT = 4;
48-
public const SIZEOF_DOUBLE = 8;
47+
private const SIZEOF_FLOAT = 4;
48+
private const SIZEOF_DOUBLE = 8;
4949

5050
public static function signByte(int $value) : int{
5151
return $value << 56 >> 56;

0 commit comments

Comments
 (0)