Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cd command failed on Windows with shell-emulator=true in .npmrc #7838

Open
3 of 4 tasks
alpheustangs opened this issue Mar 28, 2024 · 1 comment · May be fixed by pnpm/npm-lifecycle#48
Open
3 of 4 tasks

cd command failed on Windows with shell-emulator=true in .npmrc #7838

alpheustangs opened this issue Mar 28, 2024 · 1 comment · May be fixed by pnpm/npm-lifecycle#48
Labels
type: bug

Comments

@alpheustangs
Copy link

alpheustangs commented Mar 28, 2024 •
edited
Loading

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

8.15.5

Which area(s) of pnpm are affected? (leave empty if unsure)

Windows

Link to the code that reproduces this issue or a replay of the bug

https://github.com/alpheustangs/pnpm-shell-emulator-error

Reproduction steps

pnpm run cd

Describe the Bug

When using cd command in Window with shell-emulator=true in .npmrc, cd: no such file or directory error occurred. In the same time, there are no problem on mac.

Expected Behavior

Should change the directory as what the command should do.

Which Node.js version are you using?

20.12.0

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

No response
@alpheustangs alpheustangs changed the title "cd" command failed with "shell-emulator=true" in .npmrc on Windows 11 23H2 cd command failed with shell-emulator=true in .npmrc Mar 28, 2024
@alpheustangs alpheustangs changed the title cd command failed with shell-emulator=true in .npmrc cd command failed on Windows with shell-emulator=true in .npmrc Mar 28, 2024
@anatawa12
Copy link

It looks pnpm forgets making path to ppath before passing to yarnpkgs/shell?

https://github.com/pnpm/npm-lifecycle/blob/713b9714031b7a98546cbf94c556ce9a406975b4/index.js#L249-L262

https://github.com/yarnpkg/berry/blob/182046546379f3b4e111c374946b32d92be5d933/packages/yarnpkg-shell/sources/commands/entry.ts#L54

@anatawa12 anatawa12 linked a pull request Mar 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: cd builtin is not working on windows anatawa12/npm-lifecycle
2 participants
@anatawa12 @alpheustangs