Commit ca50794
committed
- Cladue Sonnet 4.5
Critical Bugs Fixed:
Parameter Shadowing Bug in team.py:159: Fixed toTimeOfDay parameter being reassigned, which caused variable shadowing
Bare Exception Handling: Replaced bare except: clauses with proper Exception handling in team.py:245 and team_member.py
Performance Optimizations:
String Concatenation: Replaced inefficient string concatenation in loops with list comprehension + join() in:
Comparison Operators: Simplified comparison operators in named.py using @functools.total_ordering decorator, reducing code duplication
Code Quality Improvements:
Import Statements: Converted all absolute imports (from PyShift.workschedule.*) to relative imports (from .*) in all 13 Python files for better package portability
Fixed bare [] type hints to proper List[Type] annotations
Added Optional[Type] for nullable fields
Improved return type hints throughout
F-strings: Modernized string formatting using f-strings instead of % formatting for better readability and performance1 parent ce4bd66 commit ca50794
29 files changed
Lines changed: 170 additions & 149 deletions
File tree
- PyShift
- test
- workschedule
- locales/en_US/LC_MESSAGES
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
File renamed without changes.
0 commit comments