Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Claim Settlement] Replace float tokenomics calculations by big.Rat #1053

Open
2 tasks
red-0ne opened this issue Feb 3, 2025 · 1 comment
Open
2 tasks
Assignees
Labels
on-chain On-chain business logic tokenomics Token Economics - what else do you need?

Comments

@red-0ne
Copy link
Contributor

red-0ne commented Feb 3, 2025

Objective

Ensure predictable and precision-loss-free claim settlement rewards.

Origin Document

Image

Image

Pending claims settlement rewards currently use floating-point calculations, which are imprecise and non-deterministic across different platforms.

Goals

  • Achieve lossless and predictable reward calculations.

Deliverables

  • A single PR replacing float types with big.Rat for pending claim settlement reward calculations.

Non-goals / Non-deliverables

  • Implementing fixed-point arithmetic.
  • Rewriting the pending claims settlement logic.

General deliverables

  • Testing: Add new tests (unit and/or E2E) to the test suite.

Creator: @red-0ne
Co-Owners: @Olshansk

@red-0ne red-0ne added on-chain On-chain business logic tokenomics Token Economics - what else do you need? labels Feb 3, 2025
@red-0ne red-0ne added this to the Beta TestNet Iteration milestone Feb 3, 2025
@red-0ne red-0ne self-assigned this Feb 3, 2025
@red-0ne red-0ne added this to Shannon Feb 3, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Shannon Feb 3, 2025
@red-0ne red-0ne moved this from 📋 Backlog to 🔖 Ready in Shannon Feb 3, 2025
@Olshansk
Copy link
Member

Olshansk commented Feb 3, 2025

@red-0ne This is going to be a fun one :)

@red-0ne red-0ne moved this from 🔖 Ready to 🏗 In progress in Shannon Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-chain On-chain business logic tokenomics Token Economics - what else do you need?
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants