Skip to content

Commit ed0dd76

Browse files
committed
WIP: temporarily commit
1 parent 28970bd commit ed0dd76

1 file changed

Lines changed: 20 additions & 12 deletions

File tree

k8s1/apps/grafana-loki/manifests.jsonnet

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ local helm_app = {
108108
// https://artifacthub.io/packages/helm/grafana/loki
109109
repoURL: 'https://grafana.github.io/helm-charts',
110110
chart: 'loki',
111-
targetRevision: '6.30.1',
111+
targetRevision: '6.39.0',
112112
helm: {
113113
releaseName: name,
114114
valuesObject: {
@@ -119,6 +119,8 @@ local helm_app = {
119119
// https://github.com/grafana/loki/blob/755e9fc14fd3a1a609e897515d9f04553a6407a5/production/helm/loki/templates/_helpers.tpl#L147-L156^C
120120
name: service_account_name,
121121
},
122+
// https://github.com/grafana/loki/blob/755e9fc14fd3a1a609e897515d9f04553a6407a5/production/helm/loki/values.yaml#L358-L359
123+
// > -- In case of using thanos storage, enable use_thanos_objstore and the configuration should be done inside the object_store section.
122124
storage: {
123125
type: 's3',
124126
bucketNames: {
@@ -128,17 +130,20 @@ local helm_app = {
128130
ruler: 'loki-ruler',
129131
admin: 'loki-admin',
130132
},
131-
s3: {
132-
type: 's3',
133-
endpoint: 'http://minio.' + minio_tenant.namespace + '.svc.cluster.local:80',
134-
insecure: true,
135-
http_config: {
136-
insecure_skip_verify: true,
133+
use_thanos_objstore: true,
134+
object_store: {
135+
s3: {
136+
type: 's3',
137+
endpoint: 'http://minio.' + minio_tenant.namespace + '.svc.cluster.local:80',
138+
insecure: true,
139+
http_config: {
140+
insecure_skip_verify: true,
141+
},
142+
// https://github.com/minio/operator/blob/e054c34ee36535b1323337816450dd7b3fcac482/pkg/controller/sts.go#L269-L271
143+
sts_endpoint: 'https://sts.' + minio_operator.namespace + '.svc.cluster.local:4223/sts/' + minio_tenant.namespace,
144+
// https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#path-style-access
145+
bucket_lookup_type: 'path',
137146
},
138-
// https://github.com/minio/operator/blob/e054c34ee36535b1323337816450dd7b3fcac482/pkg/controller/sts.go#L269-L271
139-
sts_endpoint: 'https://sts.' + minio_operator.namespace + '.svc.cluster.local:4223/sts/' + minio_tenant.namespace,
140-
// https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#path-style-access
141-
bucket_lookup_type: 'path',
142147
},
143148
},
144149
schemaConfig: {
@@ -208,7 +213,10 @@ local helm_app = {
208213
// https://github.com/grafana/loki/blob/755e9fc14fd3a1a609e897515d9f04553a6407a5/vendor/github.com/aws/aws-sdk-go-v2/config/resolve_credentials.go#L480-L482
209214
name: 'AWS_ROLE_ARN',
210215
// https://github.com/minio/minio/blob/f0b91e5504663c4672da451877857b57c3345295/internal/arn/arn.go#L27-L40
211-
value: 'arn:minio:iam::dummy:role/test', // dummy role arn
216+
// arn:partition:service:region:account-id:resource-type/resource-id
217+
// - empty region
218+
// - empty account-id
219+
value: 'arn:minio:iam:::role/loki-sa', // MinIO STS role ARN
212220
},
213221
],
214222
extraVolumes: [

0 commit comments

Comments
 (0)