Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error with action delete #4

Open
mbertrone opened this issue May 21, 2019 · 4 comments
Open

Compilation error with action delete #4

mbertrone opened this issue May 21, 2019 · 4 comments

Comments

@mbertrone
Copy link
Collaborator

When the YANG data model includes an action called delete, like in firewall service [1], the generated code includes methods called delete(...).
This is causing a compilation error because delete is a c++ reserved keyword.

A possible solution could be a check in code generation tools that adds a suffix to delete method, e.g. deletes or delete_action.

[1]

    action delete {
      input {
        uses "firewall:rule-fields";
      }
    }
@frisso
Copy link
Contributor

frisso commented May 21, 2019

Good catch!
@mauriciovasquezbernal : can we leave this to you?

@mauriciovasquezbernal mauriciovasquezbernal self-assigned this May 21, 2019
@mauriciovasquezbernal
Copy link
Contributor

Good catch!
@mauriciovasquezbernal : can we leave this to you?

Sure, I assigned myself.

@mauriciovasquezbernal
Copy link
Contributor

I don't know if at this point I could take care of this, so I am removing my assignment.

@mauriciovasquezbernal mauriciovasquezbernal removed their assignment Jul 27, 2019
@frisso
Copy link
Contributor

frisso commented Jul 28, 2019

This is really sad, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants