Skip to content

Commit 937a412

Browse files
committed
fixed capsul tests, removed th euse of obsolete traits types (ListStr..)
1 parent 81fb00c commit 937a412

File tree

5 files changed

+21
-27
lines changed

5 files changed

+21
-27
lines changed

capsul/engine/module/attributes.py

+1-8
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,11 @@
44
55
'''
66

7-
from __future__ import absolute_import
8-
9-
import os
10-
import six
117
from capsul.attributes.attributes_factory import AttributesFactory
128
from capsul.attributes.attributes_schema import AttributesSchema, \
139
ProcessAttributes
1410
from capsul.attributes.completion_engine \
1511
import ProcessCompletionEngineFactory, PathCompletionEngineFactory
16-
from capsul.engine import settings
17-
import capsul.engine
18-
import os.path as osp
1912
from functools import partial
2013
import weakref
2114

@@ -143,7 +136,7 @@ def validate_config(widget):
143136
traits.List(traits.Str(), desc='attributes shchemas modules names'))
144137
controller.add_trait(
145138
'attributes_schemas',
146-
traits.DictStrStr(desc='attributes shchemas names'))
139+
traits.Dict(str, str, desc='attributes shchemas names'))
147140
controller.add_trait(
148141
'process_completion',
149142
traits.Str(desc='process completion model name'))

capsul/engine/module/somaworkflow.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
# -*- coding: utf-8 -*-
2-
from __future__ import absolute_import
32

43
from capsul import engine
54
import traits.api as traits
65
from traits.api import Undefined
7-
import os
8-
import six
96

107

118
def init_settings(capsul_engine):
@@ -135,8 +132,8 @@ def validate_config(widget):
135132
controller.add_trait('path_translations',
136133
traits.Dict(
137134
key_trait=traits.Directory,
138-
value_trait=traits.ListStr(['', ''], minlen=2,
139-
maxlen=2),
135+
value_trait=traits.List(str)(['', ''], minlen=2,
136+
maxlen=2),
140137
value={}, output=False,
141138
desc=''))
142139

capsul/pipeline/pipeline_tools.py

+14-4
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@
4242
-----------------------
4343
'''
4444

45-
from __future__ import print_function
46-
from __future__ import absolute_import
47-
4845
# System import
4946
import os
5047
import logging
@@ -1272,7 +1269,20 @@ def load_pipeline_parameters(filename, pipeline):
12721269
except traits.TraitError:
12731270
# This case happen when the trait type is date, time or datetime
12741271
# Couldn't find an other solution for now
1275-
setattr(pipeline, trait_name, None)
1272+
if trait_value not in (None, traits.Undefined, ''):
1273+
t = pipeline.trait(trait_name)
1274+
if isinstance(t.trait_type, traits.Date):
1275+
trait_value = date.fromisoformat(trait_value)
1276+
elif isinstance(t.trait_type, traits.Time):
1277+
trait_value = time.fromisoformat(trait_value)
1278+
elif isinstance(t.trait_type, traits.Datetime):
1279+
trait_value = datetime.fromisoformat(trait_value)
1280+
else:
1281+
trait_value = None
1282+
try:
1283+
setattr(pipeline, trait_name, trait_value)
1284+
except traits.TraitError:
1285+
setattr(pipeline, trait_name, traits.Undefined)
12761286

12771287
pipeline.update_nodes_and_plugs_activation()
12781288

capsul/pipeline/test/test_pipeline_parameters.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
# -*- coding: utf-8 -*-
22

3-
from __future__ import print_function
4-
5-
from __future__ import absolute_import
63
import os
74
import json
85
import shutil
@@ -745,8 +742,8 @@ def pipeline_definition(self):
745742
# Reinitializing pipeline and loading parameters
746743
pipeline1 = Pipeline1()
747744
load_pipeline_parameters(self.path, pipeline1)
748-
self.assertEqual(pipeline1.in_1, None)
749-
self.assertEqual(pipeline1.in_2, None)
745+
self.assertEqual(pipeline1.in_1, in_1)
746+
self.assertEqual(pipeline1.in_2, in_2)
750747
self.assertEqual(pipeline1.out, out)
751748

752749
self.assertEqual(type(pipeline1.out), TraitListObject)

capsul/study_config/config_modules/attributes_config.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,7 @@
88
-------------------------
99
'''
1010

11-
from __future__ import absolute_import
12-
import os
13-
import six
14-
from traits.api import Bool, Str, Undefined, List, DictStrStr
11+
from traits.api import Str, Undefined, List, Dict
1512
from capsul.study_config.study_config import StudyConfigModule
1613
from capsul.attributes.attributes_factory import AttributesFactory
1714
from capsul.attributes.attributes_schema import AttributesSchema, \
@@ -45,7 +42,7 @@ def __init__(self, study_config, configuration):
4542
desc='attributes shchema module name', groups=['attributes']))
4643
self.study_config.add_trait(
4744
'attributes_schemas',
48-
DictStrStr(output=False,
45+
Dict(str, str, output=False,
4946
desc='attributes shchemas names', groups=['attributes']))
5047
self.study_config.add_trait(
5148
'process_completion',

0 commit comments

Comments
 (0)