Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not available on jsr.io #839

Open
shivajivarma opened this issue Mar 28, 2024 · 8 comments · May be fixed by #1034
Open

Not available on jsr.io #839

shivajivarma opened this issue Mar 28, 2024 · 8 comments · May be fixed by #1034

Comments

@shivajivarma
Copy link

No description provided.

@sant123
Copy link

sant123 commented Mar 29, 2024

Can this be published on jsr please? 🙏🏼

@sant123
Copy link

sant123 commented Sep 18, 2024

Bump on this, please 🙏🏼

@uncomfyhalomacro
Copy link

Hi team. I would also love this package to be added in the JSR.

@i18nsite
Copy link

i18nsite commented Feb 12, 2025

@i18nsite
Copy link

i18nsite commented Feb 12, 2025

fix in #1034

deno add jsr:@y0/postgres

https://jsr.io/@y0/postgres

@oscar6echo
Copy link

oscar6echo commented Mar 20, 2025

Correct me if I'm wrong but the types do not seem to be imported if you do:

// run ok but missing types
import postgres from "@y0/postgres"; 

But they are if you do:

// run and types ok
import postgres from "https://deno.land/x/postgresjs@v3.4.5/mod.js";

Cf. denoland/deno#28551 (comment)


Minor

Btw the import in jsr.io seem incorrect. I think it should be

import postgres from "@y0/postgres";

instead of:

Image

@oscar6echo
Copy link

oscar6echo commented Mar 21, 2025

This is my first attempt to fix (and learn jsr.io): https://jsr.io/@oscar6echo/postgres@3.4.5-a

Cf. Fork | commit

In essence, I changed what deno publish --dry-run errors and warnings said until it did not complain:

  • replace https://denoland/x/.etc urls with node:, npm:, jsr: packages.
  • add @types/node to package.json
  • use new // @ts-self-types= syntax to reference .d.ts types
  • replace export = postgres by export default postgres

NOTE: I don't know how to fix the automatically generated import - image above.

Will test shortly.


EDIT:

versions -b and -c just exlude unecessary files and remove package.json in favor of deno.jsonc:
https://jsr.io/@oscar6echo/postgres@3.4.5-c

@oscar6echo
Copy link

Cf. question about autogenerated imports: jsr-io/jsr#767 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants