Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL query logging #595

Closed
cayter opened this issue May 13, 2023 · 3 comments
Closed

SQL query logging #595

cayter opened this issue May 13, 2023 · 3 comments

Comments

@cayter
Copy link

cayter commented May 13, 2023

Is there a reason why this library doesn't accept logger for logging the SQL queries with time consumed? The suggested approach here doesn't work as the underlying function returns a Promise and the same method is also used for building the query.

@porsager
Copy link
Owner

porsager commented May 13, 2023 via email

@cayter
Copy link
Author

cayter commented May 13, 2023

I'm just wondering if there's a plan to add this as it'd be useful for OpenTelemetry to trace the query so that we don't have to wrap another layer or manually trace everywhere we call postgres method that runs the query.

@porsager
Copy link
Owner

There's some work on this now - I'm tracking it in #461 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants