Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible improvements to (transaction) CSV importer #3616

Open
pfalcon opened this issue Oct 29, 2023 · 1 comment
Open

Possible improvements to (transaction) CSV importer #3616

pfalcon opened this issue Oct 29, 2023 · 1 comment
Labels

Comments

@pfalcon
Copy link
Contributor

pfalcon commented Oct 29, 2023

CSV transaction importer with all its column typing and mapping is really smart and neat feature. It still falls short in various real-world cases, this ticket tries to enumerate seemingly low-hanging changes which can improve it:

  1. For the "(transaction) type", the mapping is "PortfolioPerformance internal operation" -> "value from CSV column". That's needlessly limiting, because it assumes there's a one-to-one mapping from PP's operation to what may appear in a random statement around the world. But maybe there's stuff like "Buy" vs "Buy to open" vs "Buy to close", or maybe there're different ways of depositing/transferring. So, the mapping should be the opposite, "value from CSV column" -> "PortfolioPerformance internal operation". And there should be support for many-to-one mapping. It may be a challenge (or chore) to support that in UI, but as long as that mapping can be edited in CSV importer JSON config which can be exported/imported, that's already a great improvement.
  2. CSV forcibly ignores amount signs, by calling Math.abs(). This seems to be a generic problem with PP, see e.g. Allow Negative Tax and Fee (Credits) #3450. For CSV importer, this enforces unrealistic model when each transaction would be explicitly classified as "buy" and "sell". Instead, a buy transaction would be one with the negative amount and sell - with positive (sign definitely depends on the "side" of the statement, the above is from the point of view of cash account). So, again, CSV should not just throw away sign, but use it instead.
  3. There should be a way to specify a quote feed for newly imported securities, that's Allow Negative Tax and Fee (Credits) #3450. Failing way to do that in UI (a chore to implement), a "golden standard" default feed should be set, which is Yahoo Finance.
@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 29, 2023

  1. CSV forcibly ignores amount signs

Posted #3617 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants