♻️ Remove pool env overrides from checksum

Since they're in-lined now, they no longer need to be added to checksums like vars imported from configmap/secrets. Kubernetes will roll out on in-lined env vars on its own.

Author: ThePooN

osu/osu-web/Chart.yaml

@@ -15,7 +15,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 2025.1124.1
+version: 2025.1124.2
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to

osu/osu-web/templates/_helpers.tpl

@@ -75,15 +75,6 @@ Create the name of the service account to use
 {{- end -}}
 {{- end -}}
 
-{{- define "osu-web-chart.pool-env-vars" -}}
-{{- range $key, $value := . }}
-{{- if not (kindIs "invalid" $value) -}}
-- name: {{ $key | upper | quote }}
-  value: {{ $value | quote }}
-{{- end -}}
-{{- end -}}
-{{- end -}}
-
 {{- define "osu-web-chart.env-vars" -}}
 {{ template "osu-web-chart.env-var" (dict "name" "APP_URL" "value" (include "osu-web.laravelAppUrl" .)) }}
 {{ template "osu-web-chart.env-var" (dict "name" "APP_ENV" "value" .Values.config.laravel.env) }}

osu/osu-web/templates/octane-pool.yaml

@@ -4,7 +4,6 @@
 {{- range $poolName, $pool := .Values.config.laravel.octane.pools -}}
 {{- $suffix := hasKey $pool "suffix" | ternary $pool.suffix (printf "-%s" $poolName) -}}
 {{- $resourceName := printf "%s-octane%s" (include "osu-web-chart.fullname" $) $suffix }}
-{{- $poolEnvVars := include "osu-web-chart.pool-env-vars" (default (dict) $pool.extraEnv) -}}
 ---
 apiVersion: apps/v1
 kind: Deployment
@@ -13,7 +12,7 @@ metadata:
   labels:
     {{- include "osu-web-chart.labels" (dict "root" $ "options" (dict "component" "octane" "pool" $poolName)) | nindent 4 }}
   annotations:
-    checksum/config: {{ sha256sum (printf "%s-%s-%s-%s" $.Values.config.laravel.oauth.privateKey $.Values.config.laravel.oauth.publicKey (include "osu-web-chart.env-vars" $) $poolEnvVars) }}
+    checksum/config: {{ sha256sum (printf "%s-%s-%s" $.Values.config.laravel.oauth.privateKey $.Values.config.laravel.oauth.publicKey (include "osu-web-chart.env-vars" $)) }}
 spec:
   replicas: {{ default $poolDefaults.replicas $pool.replicas }}
   {{- with (default $poolDefaults.strategy $pool.strategy) }}
@@ -26,7 +25,7 @@ spec:
   template:
     metadata:
       annotations:
-        checksum/config: {{ sha256sum (printf "%s-%s-%s-%s" $.Values.config.laravel.oauth.privateKey $.Values.config.laravel.oauth.publicKey (include "osu-web-chart.env-vars" $) $poolEnvVars) }}
+        checksum/config: {{ sha256sum (printf "%s-%s-%s" $.Values.config.laravel.oauth.privateKey $.Values.config.laravel.oauth.publicKey (include "osu-web-chart.env-vars" $)) }}
         {{- range $key, $value := (default $poolDefaults.extraPodAnnotations $pool.extraPodAnnotations) }}
         {{ $key | quote }}: {{ $value | quote }}
         {{- end }}
@@ -92,8 +91,11 @@ spec:
             {{- toYaml . | nindent 12 }}
             {{- end }}
           env:
-            {{- if gt (len $poolEnvVars) 0 }}
-            {{- $poolEnvVars | nindent 12 }}
+            {{- if and $pool.extraEnv (gt (len $pool.extraEnv) 0) }}
+            {{- range $key, $value := $pool.extraEnv }}
+            - name: {{ $key | upper | quote }}
+              value: {{ $value | quote }}
+            {{- end }}
             {{- end }}
             - name: DATADOG_STATSD_HOST
               valueFrom: