Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Played variant for daily challenge counter #11597

Open
cl8n opened this issue Oct 29, 2024 · 1 comment
Open

Played variant for daily challenge counter #11597

cl8n opened this issue Oct 29, 2024 · 1 comment

Comments

@cl8n
Copy link
Member

cl8n commented Oct 29, 2024

see the design file. this is a small update adding a variant of the daily challenge streak for when the user has completed today's challenge, already approved by flyte and myself

also, the corner radius of that darker block is supposed to be 3px, it's 6px on osu-web rn for some reason.

I wasn't sure whether to just post it here or open a discussion at https://github.com/ppy/osu-design, the latter felt kind of overkill for such a tiny thing but maybe I'm overthinking it, I'm not sure. we're still figuring this out lol

this is a response to https://discord.com/channels/188630481301012481/1097318920991559880/1300323179457151069

@cl8n cl8n converted this from a draft issue Oct 29, 2024
@cl8n cl8n changed the title Quick Fix: Daily Challenge Streak Played variant for daily challenge streak Oct 29, 2024
@cl8n cl8n changed the title Played variant for daily challenge streak Played variant for daily challenge counter Oct 29, 2024
@cl8n cl8n moved this from In progress to Completed in Design tracker Nov 4, 2024
@bdach bdach self-assigned this Jan 8, 2025
bdach added a commit to bdach/osu-web that referenced this issue Jan 9, 2025
bdach added a commit to bdach/osu-web that referenced this issue Jan 9, 2025
@bdach
Copy link
Contributor

bdach commented Jan 9, 2025

I'll do the client change for this after the web pull has gone through review paces, since I'm not 100% on the web pull to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

No branches or pull requests

2 participants