Skip to content

Commit 94d9de9

Browse files
authored
Add explanations for scoring mode used in ranked & total score tooltips (#36663)
Because people get confused by how this works. Shows on results screen where the post-play statistics updates go. https://github.com/user-attachments/assets/ef3a91d1-86dd-4029-8f0f-bdf0b727ca6c
1 parent 860427e commit 94d9de9

File tree

4 files changed

+12
-1
lines changed

4 files changed

+12
-1
lines changed

osu.Game/Localisation/RankingStatisticsStrings.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,11 @@ public static class RankingStatisticsStrings
3434
/// </summary>
3535
public static LocalisableString NotAvailable => new TranslatableString(getKey(@"not_available"), @"(not available)");
3636

37+
/// <summary>
38+
/// "Classic scoring mode is always used for this statistic."
39+
/// </summary>
40+
public static LocalisableString ClassicScoringAlwaysUsed => new TranslatableString(getKey(@"classic_scoring_always_used"), @"Classic scoring mode is always used for this statistic.");
41+
3742
private static string getKey(string key) => $@"{prefix}:{key}";
3843
}
3944
}

osu.Game/Screens/Ranking/Statistics/User/RankedScoreChangeRow.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
using osu.Framework.Extensions.LocalisationExtensions;
55
using osu.Framework.Localisation;
6+
using osu.Game.Localisation;
67
using osu.Game.Resources.Localisation.Web;
78

89
namespace osu.Game.Screens.Ranking.Statistics.User
@@ -15,6 +16,7 @@ public RankedScoreChangeRow()
1516
}
1617

1718
protected override LocalisableString Label => UsersStrings.ShowStatsRankedScore;
19+
public override LocalisableString TooltipText => RankingStatisticsStrings.ClassicScoringAlwaysUsed;
1820

1921
protected override LocalisableString FormatCurrentValue(long current) => current.ToLocalisableString(@"N0");
2022

osu.Game/Screens/Ranking/Statistics/User/RankingChangeRow.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
using osu.Framework.Bindables;
77
using osu.Framework.Graphics;
88
using osu.Framework.Graphics.Containers;
9+
using osu.Framework.Graphics.Cursor;
910
using osu.Framework.Graphics.Shapes;
1011
using osu.Framework.Graphics.Sprites;
1112
using osu.Framework.Localisation;
@@ -17,7 +18,7 @@
1718

1819
namespace osu.Game.Screens.Ranking.Statistics.User
1920
{
20-
public abstract partial class RankingChangeRow<T> : CompositeDrawable
21+
public abstract partial class RankingChangeRow<T> : CompositeDrawable, IHasTooltip
2122
{
2223
public Bindable<ScoreBasedUserStatisticsUpdate?> StatisticsUpdate { get; } = new Bindable<ScoreBasedUserStatisticsUpdate?>();
2324

@@ -153,6 +154,7 @@ private void onStatisticsUpdate(ValueChangedEvent<ScoreBasedUserStatisticsUpdate
153154
}
154155

155156
protected abstract LocalisableString Label { get; }
157+
public virtual LocalisableString TooltipText => default;
156158

157159
protected abstract LocalisableString FormatCurrentValue(T current);
158160
protected abstract int CalculateDifference(T previous, T current, out LocalisableString formattedDifference);

osu.Game/Screens/Ranking/Statistics/User/TotalScoreChangeRow.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
using osu.Framework.Extensions.LocalisationExtensions;
55
using osu.Framework.Localisation;
6+
using osu.Game.Localisation;
67
using osu.Game.Resources.Localisation.Web;
78

89
namespace osu.Game.Screens.Ranking.Statistics.User
@@ -15,6 +16,7 @@ public TotalScoreChangeRow()
1516
}
1617

1718
protected override LocalisableString Label => UsersStrings.ShowStatsTotalScore;
19+
public override LocalisableString TooltipText => RankingStatisticsStrings.ClassicScoringAlwaysUsed;
1820

1921
protected override LocalisableString FormatCurrentValue(long current) => current.ToLocalisableString(@"N0");
2022

0 commit comments

Comments
 (0)