Use the last version of practicalmeteor:mocha#9
Open
serut wants to merge 1 commit into
Open
Conversation
|
2.4.5_5 is causing issues in my console output, that 2.4.5_6 doesn't seem to have, any chance of this getting in soon? |
|
plus one for merging this and getting reporters to work |
|
Is there a strong argument not to merge this? |
|
Having tested, I can confirm that this now breaks when using spacejam for CI reporting @serut @thebarty, I assume its an bug or issue in practicalmeteor:[email protected]_6, @serut - this seems to create some minor issues with meteor-coverage as discussed there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior
meteor add practicalmeteor:mocha practicalmeteor:mocha-console-runnerwill install the last version of
mocha-console-runner, which meanspracticalmeteor:[email protected]_5Quick fix
meteor add practicalmeteor:[email protected]_6 practicalmeteor:mocha-console-runnerTodo
test-apptest-package.versions