Skip to content

Commit 1d2eb4b

Browse files
bbejeckpranavt84
authored andcommitted
use version.py get_version to get version (apache#18563)
A prior commit introduced checking for the version of a node related to move to log4j2 but it was causing an error AttributeError("'ClusterNode' object has no attribute 'version'") This PR uses the get_version method from version.py which checks if the Node has a version attribute preventing an error. Reviewers: Matthias Sax <[email protected]>
1 parent 892351a commit 1d2eb4b

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

tests/kafkatest/tests/streams/streams_relational_smoke_test.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
from kafkatest.services.streams import StreamsTestBaseService
2323
from kafkatest.tests.kafka_test import KafkaTest
2424
from kafkatest.version import LATEST_4_0
25+
from kafkatest.version import get_version
2526

2627

2728
class StreamsRelationalSmokeTestService(StreamsTestBaseService):
@@ -35,7 +36,7 @@ def __init__(self, test_context, kafka, mode, nodeId, processing_guarantee):
3536
self.mode = mode
3637
self.nodeId = nodeId
3738
self.processing_guarantee = processing_guarantee
38-
self.log4j_template = "log4j2_template.yaml" if (self.node.version >= LATEST_4_0) else "log4j_template.properties"
39+
self.log4j_template = "log4j2_template.yaml" if (get_version(self.node) >= LATEST_4_0) else "log4j_template.properties"
3940

4041
def start_cmd(self, node):
4142
return "( export KAFKA_LOG4J_OPTS=\"%(log4j_param)s%(log4j)s\"; " \
@@ -58,7 +59,7 @@ def start_cmd(self, node):
5859
def start_node(self, node):
5960
node.account.mkdirs(self.PERSISTENT_ROOT)
6061
node.account.create_file(get_log4j_config_for_tools(node),
61-
self.render("log4j2_template.yaml" if node.version >= LATEST_4_0 else "log4j_template.properties",
62+
self.render("log4j2_template.yaml" if get_version(node) >= LATEST_4_0 else "log4j_template.properties",
6263
log_file=self.LOG_FILE))
6364

6465
self.logger.info("Starting process on " + str(node.account))

0 commit comments

Comments
 (0)